Skip to content

Commit b95a516

Browse files
authored
Revert "Update assembly version from hardcoded to MajorVersion (#74157)" (#77899)
This reverts commit f84c1b5.
1 parent a4e98d4 commit b95a516

File tree

25 files changed

+73
-130
lines changed

25 files changed

+73
-130
lines changed

eng/Versions.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
<PreReleaseVersionIteration>1</PreReleaseVersionIteration>
1515
<!-- Set assembly version to align with major and minor version,
1616
as for the patches and revisions should be manually updated per assembly if it is serviced. -->
17-
<AssemblyVersion>$(MajorVersion).$(MinorVersion).0.0</AssemblyVersion>
17+
<AssemblyVersion>7.$(MinorVersion).0.0</AssemblyVersion>
1818
<!-- Enable to remove prerelease label. -->
1919
<StabilizePackageVersion Condition="'$(StabilizePackageVersion)' == ''">false</StabilizePackageVersion>
2020
<DotNetFinalVersionKind Condition="'$(StabilizePackageVersion)' == 'true'">release</DotNetFinalVersionKind>

eng/testing/ForXHarness.Directory.Build.props

Lines changed: 0 additions & 10 deletions
This file was deleted.

eng/testing/ForXHarness.Directory.Build.targets

Lines changed: 0 additions & 4 deletions
This file was deleted.

eng/testing/linker/SupportFiles/Directory.Build.targets

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<Project>
22
<Import Project="$(RepositoryEngineeringDir)testing\tests.mobile.targets" Condition="'$(RuntimeIdentifier)' == 'browser-wasm'" />
3-
<Import Project="$(RepositoryEngineeringDir)targetingpacks.targets" Condition="'$(TargetingpacksTargetsImported)' != 'true'" />
3+
<Import Project="$(RepositoryEngineeringDir)targetingpacks.targets" />
44

55
<PropertyGroup>
66
<BundleDir>$([MSBuild]::NormalizeDirectory('$(MSBuildProjectDirectory)', '$(OutputPath)', 'AppBundle'))</BundleDir>

src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.helix.targets

Lines changed: 0 additions & 17 deletions
This file was deleted.

src/libraries/Common/tests/System/Net/Prerequisites/LocalEchoServer.props

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
<Project>
22
<PropertyGroup Condition="'$(TargetOS)' == 'Browser'">
3-
<_TargetFrameworkForXHarness>$(AspNetCoreAppCurrent)</_TargetFrameworkForXHarness>
4-
<HelixTargetsFile>$(MSBuildThisFileDirectory)LocalEchoServer.helix.targets</HelixTargetsFile>
5-
63
<!-- handle different path to middleware in Helix -->
74
<_TestEchoMiddleware Condition="'$(ContinuousIntegrationBuild)' == 'true' and '$(OS)' == 'Windows_NT'">%HELIX_CORRELATION_PAYLOAD%/xharness/TestEchoMiddleware</_TestEchoMiddleware>
85
<_TestEchoMiddleware Condition="'$(ContinuousIntegrationBuild)' == 'true' and '$(OS)' != 'Windows_NT'">$HELIX_CORRELATION_PAYLOAD/xharness/TestEchoMiddleware</_TestEchoMiddleware>
@@ -18,25 +15,6 @@
1815
<WasmXHarnessArgs>$(WasmXHarnessArgs) --web-server-middleware=$(_RemoteLoopMiddleware)/RemoteLoopServer.dll,RemoteLoopServer.GenericHandler</WasmXHarnessArgs>
1916
<WasmXHarnessArgs>$(WasmXHarnessArgs) --web-server-middleware=$(_TestEchoMiddleware)/NetCoreServer.dll,NetCoreServer.GenericHandler</WasmXHarnessArgs>
2017
</PropertyGroup>
21-
22-
<ItemGroup Condition="'$(TargetOS)' == 'Browser'">
23-
<!-- The middleware doesn't need to be built for browser-wasm, so remove the relevant properties.
24-
Also, due to https://github.com/dotnet/runtime/issues/77707 RunAOTCompilation needs to be removed
25-
as a workaround. -->
26-
<ProjectReference
27-
Include="$(CommonTestPath)System/Net/Prerequisites/NetCoreServer/NetCoreServer.csproj"
28-
GlobalPropertiesToRemove="TargetOS;TargetArchitecture;RuntimeIdentifier;RunAOTCompilation"
29-
AdditionalProperties="_TargetFrameworkForXHarness=$(_TargetFrameworkForXHarness);NewtonsoftJsonVersion=$(NewtonsoftJsonVersion)"
30-
ReferenceOutputAssembly="false"/>
31-
<ProjectReference
32-
Include="$(CommonTestPath)System/Net/Prerequisites/RemoteLoopServer/RemoteLoopServer.csproj"
33-
GlobalPropertiesToRemove="TargetOS;TargetArchitecture;RuntimeIdentifier;RunAOTCompilation"
34-
AdditionalProperties="_TargetFrameworkForXHarness=$(_TargetFrameworkForXHarness)"
35-
ReferenceOutputAssembly="false"/>
36-
<Compile Include="$(CommonTestPath)System\Net\WebSockets\WebSocketStream.cs"
37-
Link="Common\System\Net\WebSockets\WebSocketStream.cs" />
38-
</ItemGroup>
39-
4018

4119
<!-- Tests use self-signed certificates that are refused by NodeJS -->
4220
<Target Name="AcceptUnauthorizedOnNodeJS" BeforeTargets="GenerateRunScript">

src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer/Directory.Build.props

Lines changed: 0 additions & 7 deletions
This file was deleted.

src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer/Directory.Build.targets

Lines changed: 0 additions & 7 deletions
This file was deleted.

src/libraries/Common/tests/System/Net/Prerequisites/NetCoreServer/NetCoreServer.csproj

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
11
<Project Sdk="Microsoft.NET.Sdk.Web">
22

33
<PropertyGroup>
4-
<TargetFramework>$(_TargetFrameworkForXHarness)</TargetFramework>
5-
<TargetFramework Condition="'$(TargetFramework)' == ''">$(AspNetCoreAppCurrent)</TargetFramework>
4+
<TargetFramework>$(AspNetCoreAppCurrent)</TargetFramework>
65
<AspNetCoreHostingModel>InProcess</AspNetCoreHostingModel>
76
<OutputType>Exe</OutputType>
87
<EnableDefaultCompileItems>false</EnableDefaultCompileItems>
9-
<EnableDefaultContentItems>false</EnableDefaultContentItems>
108

119
<DefineConstants Condition="'$(GenevaTelemetry)' == 'true'">$(DefineConstants);GENEVA_TELEMETRY</DefineConstants>
1210
</PropertyGroup>

src/libraries/Common/tests/System/Net/Prerequisites/RemoteLoopServer/Directory.Build.props

Lines changed: 0 additions & 7 deletions
This file was deleted.

0 commit comments

Comments
 (0)