Skip to content

Commit ba055bd

Browse files
ViktorHoferbartonjs
ViktorHofer
and
bartonjs
authored
Minimize the build graph by deleting unnecessary references (#68603)
* Minimize the build graph by deleting references Minimizing projects' dependency graph. There are tons of unnecessary Reference and ProjectReference items which aren't required anymore as the referenced projects became full facade assemblies. Removing those from a leaf's graph makes the graph smaller and therefore the project's evaluation and build faster. * Update src/libraries/System.Net.Quic/ref/System.Net.Quic.csproj Co-authored-by: Jeremy Barton <[email protected]> * Update Versions.props Co-authored-by: Jeremy Barton <[email protected]>
1 parent f10cdda commit ba055bd

File tree

140 files changed

+133
-401
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

140 files changed

+133
-401
lines changed

‎eng/Versions.props‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -89,31 +89,21 @@
8989
<!-- Libraries dependencies -->
9090
<MicrosoftBclAsyncInterfacesVersion>6.0.0</MicrosoftBclAsyncInterfacesVersion>
9191
<MicrosoftBclHashCodeVersion>1.1.1</MicrosoftBclHashCodeVersion>
92-
<MicrosoftWin32PrimitivesVersion>4.3.0</MicrosoftWin32PrimitivesVersion>
9392
<MicrosoftWin32RegistryVersion>5.0.0</MicrosoftWin32RegistryVersion>
9493
<StyleCopAnalyzersVersion>1.2.0-beta.406</StyleCopAnalyzersVersion>
9594
<SystemBuffersVersion>4.5.1</SystemBuffersVersion>
96-
<SystemCollectionsVersion>4.3.0</SystemCollectionsVersion>
9795
<SystemComponentModelAnnotationsVersion>5.0.0</SystemComponentModelAnnotationsVersion>
9896
<SystemDataSqlClientVersion>4.8.3</SystemDataSqlClientVersion>
9997
<SystemDataDataSetExtensionsVersion>4.5.0</SystemDataDataSetExtensionsVersion>
100-
<SystemDiagnosticsContractsVersion>4.3.0</SystemDiagnosticsContractsVersion>
101-
<SystemDynamicRuntimeVersion>4.3.0</SystemDynamicRuntimeVersion>
10298
<SystemIOFileSystemAccessControlVersion>5.0.0</SystemIOFileSystemAccessControlVersion>
10399
<SystemIOPipesAccessControlVersion>5.0.0</SystemIOPipesAccessControlVersion>
104-
<SystemLinqExpressionsVersion>4.3.0</SystemLinqExpressionsVersion>
105100
<SystemMemoryVersion>4.5.4</SystemMemoryVersion>
106-
<SystemNetPrimitivesVersion>4.3.1</SystemNetPrimitivesVersion>
107101
<SystemNumericsVectorsVersion>4.5.0</SystemNumericsVectorsVersion>
108102
<SystemReflectionMetadataVersion>6.0.0</SystemReflectionMetadataVersion>
109103
<SystemReflectionEmitVersion>4.7.0</SystemReflectionEmitVersion>
110104
<SystemReflectionEmitILGenerationVersion>4.7.0</SystemReflectionEmitILGenerationVersion>
111105
<SystemReflectionEmitLightweightVersion>4.7.0</SystemReflectionEmitLightweightVersion>
112-
<SystemRuntimeVersion>4.3.1</SystemRuntimeVersion>
113-
<SystemRuntimeExtensionsVersion>4.3.1</SystemRuntimeExtensionsVersion>
114-
<SystemRuntimeInteropServicesVersion>4.3.0</SystemRuntimeInteropServicesVersion>
115106
<SystemRuntimeInteropServicesRuntimeInformationVersion>4.3.0</SystemRuntimeInteropServicesRuntimeInformationVersion>
116-
<SystemRuntimeSerializationPrimitivesVersion>4.3.0</SystemRuntimeSerializationPrimitivesVersion>
117107
<SystemSecurityAccessControlVersion>6.0.0</SystemSecurityAccessControlVersion>
118108
<SystemSecurityCryptographyAlgorithmsVersion>4.3.1</SystemSecurityCryptographyAlgorithmsVersion>
119109
<SystemSecurityCryptographyCngVersion>5.0.0</SystemSecurityCryptographyCngVersion>

‎src/libraries/Microsoft.CSharp/ref/Microsoft.CSharp.csproj‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@
22
<PropertyGroup>
33
<TargetFramework>$(NetCoreAppCurrent)</TargetFramework>
44
</PropertyGroup>
5+
56
<ItemGroup>
67
<Compile Include="Microsoft.CSharp.cs" />
78
</ItemGroup>
89

910
<ItemGroup>
10-
<ProjectReference Include="..\..\System.Linq\ref\System.Linq.csproj" />
1111
<ProjectReference Include="..\..\System.Linq.Expressions\ref\System.Linq.Expressions.csproj" />
1212
<ProjectReference Include="..\..\System.Runtime\ref\System.Runtime.csproj" />
1313
</ItemGroup>

‎src/libraries/Microsoft.CSharp/src/Microsoft.CSharp.csproj‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -239,21 +239,15 @@
239239
<Reference Include="System.Reflection.Emit.ILGeneration" />
240240
<Reference Include="System.Reflection.Emit.Lightweight" />
241241
<Reference Include="System.Reflection.Primitives" />
242-
<Reference Include="System.Runtime.CompilerServices.Unsafe" />
243242
</ItemGroup>
244243
<ItemGroup>
245244
<Reference Include="System.Collections" />
246245
<Reference Include="System.Collections.Concurrent" />
247-
<Reference Include="System.Diagnostics.Debug" />
248-
<Reference Include="System.Diagnostics.Tools" />
249246
<Reference Include="System.Linq" />
250247
<Reference Include="System.Linq.Expressions" />
251248
<Reference Include="System.Memory" />
252249
<Reference Include="System.ObjectModel" />
253-
<Reference Include="System.Reflection" />
254-
<Reference Include="System.Resources.ResourceManager" />
255250
<Reference Include="System.Runtime" />
256-
<Reference Include="System.Runtime.Extensions" />
257251
<Reference Include="System.Runtime.InteropServices" />
258252
<Reference Include="System.Threading" />
259253
</ItemGroup>

‎src/libraries/Microsoft.Extensions.Configuration.Xml/tests/Microsoft.Extensions.Configuration.Xml.Tests.csproj‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@
2222

2323
<ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'">
2424
<Reference Include="System.Security" />
25-
<!-- Manually reference the transitive dependency to make NuGet pick the package over the transitive project: https://github.com/NuGet/Home/issues/10368 -->
26-
<PackageReference Include="System.Security.Principal.Windows" Version="$(SystemSecurityPrincipalWindowsVersion)" PrivateAssets="all" />
2725
</ItemGroup>
2826

2927
</Project>

‎src/libraries/Microsoft.Extensions.Configuration/tests/FunctionalTests/Microsoft.Extensions.Configuration.Functional.Tests.csproj‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,4 @@
2222
<ProjectReference Include="$(LibrariesProjectRoot)Microsoft.Extensions.Configuration.Xml\src\Microsoft.Extensions.Configuration.Xml.csproj" />
2323
</ItemGroup>
2424

25-
<ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'">
26-
<!-- Manually reference the transitive dependency to make NuGet pick the package over the transitive project: https://github.com/NuGet/Home/issues/10368 -->
27-
<PackageReference Include="System.Security.Principal.Windows" Version="$(SystemSecurityPrincipalWindowsVersion)" PrivateAssets="all" />
28-
</ItemGroup>
29-
3025
</Project>

‎src/libraries/Microsoft.Extensions.DependencyInjection/tests/DI.External.Tests/Microsoft.Extensions.DependencyInjection.ExternalContainers.Tests.csproj‎

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -27,16 +27,5 @@
2727
<ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETCoreApp'">
2828
<PackageReference Include="Lamar.Microsoft.DependencyInjection" Version="8.0.0" />
2929
</ItemGroup>
30-
31-
<!-- Include these transitive dependencies to overrule NuGet's ProjectReference over PackageReferene behavior: https://github.com/NuGet/Home/issues/9354. -->
32-
<ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'">
33-
<PackageReference Include="Microsoft.Win32.Primitives" Version="$(MicrosoftWin32PrimitivesVersion)" />
34-
<PackageReference Include="System.Memory" Version="$(SystemMemoryVersion)" />
35-
<PackageReference Include="System.Runtime" Version="$(SystemRuntimeVersion)" />
36-
<PackageReference Include="System.Runtime.Extensions" Version="$(SystemRuntimeExtensionsVersion)" />
37-
<PackageReference Include="System.Net.Primitives" Version="$(SystemNetPrimitivesVersion)" />
38-
<PackageReference Include="System.Collections" Version="$(SystemCollectionsVersion)" />
39-
<PackageReference Include="System.Runtime.InteropServices" Version="$(SystemRuntimeInteropServicesVersion)" />
40-
</ItemGroup>
4130

4231
</Project>

‎src/libraries/Microsoft.VisualBasic.Core/ref/Microsoft.VisualBasic.Core.csproj‎

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,13 @@
22
<PropertyGroup>
33
<TargetFramework>$(NetCoreAppCurrent)</TargetFramework>
44
</PropertyGroup>
5+
56
<ItemGroup>
67
<Compile Include="Microsoft.VisualBasic.Core.cs" />
78
</ItemGroup>
9+
810
<ItemGroup>
9-
<ProjectReference Include="..\..\System.ComponentModel\ref\System.ComponentModel.csproj" />
10-
<ProjectReference Include="..\..\System.IO.FileSystem.DriveInfo\ref\System.IO.FileSystem.DriveInfo.csproj" />
11-
<ProjectReference Include="..\..\System.Runtime\ref\System.Runtime.csproj" />
12-
<ProjectReference Include="..\..\System.Runtime.Extensions\ref\System.Runtime.Extensions.csproj" />
13-
<ProjectReference Include="..\..\System.Runtime.InteropServices\ref\System.Runtime.InteropServices.csproj" />
14-
<ProjectReference Include="..\..\System.Security.Principal\ref\System.Security.Principal.csproj" />
15-
<ProjectReference Include="..\..\System.Threading.Thread\ref\System.Threading.Thread.csproj" />
11+
<ProjectReference Include="$(LibrariesProjectRoot)System.IO.FileSystem.DriveInfo\ref\System.IO.FileSystem.DriveInfo.csproj" />
12+
<ProjectReference Include="$(LibrariesProjectRoot)System.Runtime\ref\System.Runtime.csproj" />
1613
</ItemGroup>
1714
</Project>

‎src/libraries/Microsoft.VisualBasic.Core/src/Microsoft.VisualBasic.Core.vbproj‎

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -105,33 +105,19 @@
105105
<Reference Include="System.Collections" />
106106
<Reference Include="System.Collections.NonGeneric" />
107107
<Reference Include="System.Collections.Specialized" />
108-
<Reference Include="System.ComponentModel" />
109108
<Reference Include="System.ComponentModel.Primitives" />
110-
<Reference Include="System.Diagnostics.Debug" />
111109
<Reference Include="System.Diagnostics.Process" />
112-
<Reference Include="System.Dynamic.Runtime" />
113-
<Reference Include="System.Globalization" />
114-
<Reference Include="System.IO" />
115-
<Reference Include="System.IO.FileSystem" />
116110
<Reference Include="System.IO.FileSystem.DriveInfo" />
117111
<Reference Include="System.Linq" />
118112
<Reference Include="System.Linq.Expressions" />
119113
<Reference Include="System.ObjectModel" />
120-
<Reference Include="System.Reflection" />
121-
<Reference Include="System.Reflection.Emit" />
122114
<Reference Include="System.Reflection.Emit.ILGeneration" />
123115
<Reference Include="System.Reflection.Emit.Lightweight" />
124-
<Reference Include="System.Reflection.Extensions" />
125116
<Reference Include="System.Reflection.Primitives" />
126-
<Reference Include="System.Reflection.TypeExtensions" />
127-
<Reference Include="System.Resources.ResourceManager" />
128117
<Reference Include="System.Runtime" />
129-
<Reference Include="System.Runtime.Extensions" />
130118
<Reference Include="System.Runtime.InteropServices" />
131-
<Reference Include="System.Security.Principal" />
132119
<Reference Include="System.Text.RegularExpressions" />
133120
<Reference Include="System.Threading" />
134-
<Reference Include="System.Threading.Tasks" />
135121
<Reference Include="System.Threading.Thread" />
136122
</ItemGroup>
137123
</Project>

‎src/libraries/Microsoft.Win32.Registry.AccessControl/ref/Microsoft.Win32.Registry.AccessControl.csproj‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,5 @@
1111
<ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">
1212
<PackageReference Include="Microsoft.Win32.Registry" Version="$(MicrosoftWin32RegistryVersion)" />
1313
<PackageReference Include="System.Security.AccessControl" Version="$(SystemSecurityAccessControlVersion)" />
14-
<!-- Manually reference the transitive dependency to make NuGet pick the package over the transitive project: https://github.com/NuGet/Home/issues/10368 -->
15-
<PackageReference Include="System.Memory" Version="$(SystemMemoryVersion)" PrivateAssets="all" />
16-
<PackageReference Include="System.Security.Principal.Windows" Version="$(SystemSecurityPrincipalWindowsVersion)" PrivateAssets="all" />
1714
</ItemGroup>
1815
</Project>

‎src/libraries/Microsoft.Win32.Registry.AccessControl/tests/Microsoft.Win32.Registry.AccessControl.Tests.csproj‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,5 @@
77
</ItemGroup>
88
<ItemGroup>
99
<ProjectReference Include="..\src\Microsoft.Win32.Registry.AccessControl.csproj" />
10-
<!-- Manually reference the transitive dependency to make NuGet pick the package over the transitive project: https://github.com/NuGet/Home/issues/10368 -->
11-
<PackageReference Include="System.Security.Principal.Windows" Version="$(SystemSecurityPrincipalWindowsVersion)" PrivateAssets="all" />
1210
</ItemGroup>
1311
</Project>

0 commit comments

Comments
 (0)