Skip to content

Commit ee7c253

Browse files
authored
[wasm] Fix perf pipeline (#89091)
Passing arguments to bdn as `"--wasmArgs=--expose_wasm --module"` broke with the latest update. Now this gets incorrectly parsed. Instead, what works is: `--wasmArgs "--expose_wasm --module"`.
1 parent f2fa057 commit ee7c253

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

eng/testing/performance/performance-setup.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -410,7 +410,7 @@ if [[ -n "$wasm_bundle_directory" ]]; then
410410
fi
411411

412412
# Workaround: escaping the quotes around `--wasmArgs=..` so they get retained for the actual command line
413-
extra_benchmark_dotnet_arguments="$extra_benchmark_dotnet_arguments --wasmEngine /home/helixbot/.jsvu/$javascript_engine \\\"--wasmArgs=$wasm_args \\\" --cli \$HELIX_CORRELATION_PAYLOAD/dotnet/dotnet --wasmDataDir \$HELIX_CORRELATION_PAYLOAD/wasm-data"
413+
extra_benchmark_dotnet_arguments="$extra_benchmark_dotnet_arguments --wasmEngine /home/helixbot/.jsvu/$javascript_engine --wasmArgs \\\"$wasm_args\\\" --cli \$HELIX_CORRELATION_PAYLOAD/dotnet/dotnet --wasmDataDir \$HELIX_CORRELATION_PAYLOAD/wasm-data"
414414
if [[ "$wasmaot" == "true" ]]; then
415415
extra_benchmark_dotnet_arguments="$extra_benchmark_dotnet_arguments --aotcompilermode wasm --buildTimeout 3600"
416416
fi

0 commit comments

Comments
 (0)