Skip to content

Commit f39b1f9

Browse files
committed
Simplify constant TimeSpan retrieval
`TimeSpan.Parse` may behave differently depending on culture settings.
1 parent d58e9aa commit f39b1f9

File tree

3 files changed

+2
-6
lines changed

3 files changed

+2
-6
lines changed

src/libraries/System.Transactions.Local/src/System/Transactions/Configuration/ConfigurationStrings.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,5 @@ namespace System.Transactions.Configuration
66
internal static class ConfigurationStrings
77
{
88
internal const string DefaultDistributedTransactionManagerName = "";
9-
internal const string DefaultMaxTimeout = "00:10:00";
10-
internal const string DefaultTimeout = "00:01:00";
119
}
1210
}

src/libraries/System.Transactions.Local/src/System/Transactions/Configuration/DefaultSettingsSection.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,11 @@ namespace System.Transactions.Configuration
66
internal sealed class DefaultSettingsSection // ConfigurationSection
77
{
88
private static readonly DefaultSettingsSection s_section = new DefaultSettingsSection();
9-
private static readonly TimeSpan s_timeout = TimeSpan.Parse(ConfigurationStrings.DefaultTimeout);
109

1110
internal static DefaultSettingsSection GetSection() => s_section;
1211

1312
public static string DistributedTransactionManagerName { get; set; } = ConfigurationStrings.DefaultDistributedTransactionManagerName;
1413

15-
public static TimeSpan Timeout => s_timeout;
14+
public static TimeSpan Timeout => TimeSpan.FromMinutes(1);
1615
}
1716
}

src/libraries/System.Transactions.Local/src/System/Transactions/Configuration/MachineSettingsSection.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,9 @@ namespace System.Transactions.Configuration
66
internal sealed class MachineSettingsSection // ConfigurationSection
77
{
88
private static readonly MachineSettingsSection s_section = new MachineSettingsSection();
9-
private static readonly TimeSpan s_maxTimeout = TimeSpan.Parse(ConfigurationStrings.DefaultMaxTimeout);
109

1110
internal static MachineSettingsSection GetSection() => s_section;
1211

13-
public static TimeSpan MaxTimeout => s_maxTimeout;
12+
public static TimeSpan MaxTimeout => TimeSpan.FromMinutes(10);
1413
}
1514
}

0 commit comments

Comments
 (0)