Skip to content

Commit fde468b

Browse files
committed
Change win-x86 configuration to build with FEATURE_EH_FUNCLETS
1 parent 3c1969d commit fde468b

File tree

3 files changed

+2
-10
lines changed

3 files changed

+2
-10
lines changed

src/coreclr/clr.featuredefines.props

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
<PropertyGroup>
33
<FeatureCoreCLR>true</FeatureCoreCLR>
44
<FeaturePerfTracing>true</FeaturePerfTracing>
5+
<FeatureEHFunclets>true</FeatureEHFunclets>
56
<ProfilingSupportedBuild>true</ProfilingSupportedBuild>
67
</PropertyGroup>
78

@@ -22,10 +23,6 @@
2223
<FeatureObjCMarshal>true</FeatureObjCMarshal>
2324
</PropertyGroup>
2425

25-
<PropertyGroup Condition="!('$(TargetsWindows)' == 'true' AND '$(Platform)' == 'x86')">
26-
<FeatureEHFunclets>true</FeatureEHFunclets>
27-
</PropertyGroup>
28-
2926
<PropertyGroup>
3027
<DefineConstants Condition="'$(FeatureComWrappers)' == 'true'">$(DefineConstants);FEATURE_COMWRAPPERS</DefineConstants>
3128
<DefineConstants Condition="'$(FeatureCominterop)' == 'true'">$(DefineConstants);FEATURE_COMINTEROP</DefineConstants>

src/coreclr/clrdefinitions.cmake

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -205,9 +205,7 @@ if(CLR_CMAKE_TARGET_WIN32)
205205
endif(CLR_CMAKE_TARGET_ARCH_AMD64 OR CLR_CMAKE_TARGET_ARCH_I386)
206206
endif(CLR_CMAKE_TARGET_WIN32)
207207

208-
if (NOT CLR_CMAKE_TARGET_ARCH_I386 OR NOT CLR_CMAKE_TARGET_WIN32)
209-
add_compile_definitions($<$<NOT:$<BOOL:$<TARGET_PROPERTY:IGNORE_DEFAULT_TARGET_ARCH>>>:FEATURE_EH_FUNCLETS>)
210-
endif (NOT CLR_CMAKE_TARGET_ARCH_I386 OR NOT CLR_CMAKE_TARGET_WIN32)
208+
add_compile_definitions($<$<NOT:$<BOOL:$<TARGET_PROPERTY:IGNORE_DEFAULT_TARGET_ARCH>>>:FEATURE_EH_FUNCLETS>)
211209

212210
if (CLR_CMAKE_TARGET_WIN32 AND (CLR_CMAKE_TARGET_ARCH_AMD64 OR CLR_CMAKE_TARGET_ARCH_ARM64))
213211
add_definitions(-DFEATURE_SPECIAL_USER_MODE_APC)

src/coreclr/jit/targetx86.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,6 @@
5252
// target
5353
#define FEATURE_EH 1 // To aid platform bring-up, eliminate exceptional EH clauses (catch, filter,
5454
// filter-handler, fault) and directly execute 'finally' clauses.
55-
#if !defined(UNIX_X86_ABI)
56-
#define FEATURE_EH_WINDOWS_X86 1 // Enable support for SEH regions
57-
#endif
5855
#define ETW_EBP_FRAMED 1 // if 1 we cannot use EBP as a scratch register and must create EBP based
5956
// frames for most methods
6057
#define CSE_CONSTS 1 // Enable if we want to CSE constants

0 commit comments

Comments
 (0)