System.Runtime.Serialization.Formatters: fix target framework check for source-build. #104735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or source-build. The inbox implementation should no longer include a working binary formatter. The check used to build a working formatter was '$(TargetFramework)' == '$(NetCoreAppMinimum)'. Because NetCoreAppMinimum gets set to TargetFramework in the source-build configuration, the source-build configuration unintentionally included a working binary formatter.
ghost
added
the
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
ViktorHofer
reviewed
Jul 11, 2024
...s/System.Runtime.Serialization.Formatters/ref/System.Runtime.Serialization.Formatters.csproj
Outdated
Show resolved
Hide resolved
ViktorHofer
approved these changes
Jul 11, 2024
This was referenced Jul 11, 2024
Open
|
Thanks for your assistance, @ViktorHofer! |
|
/ba-g queues are timing out, known issue |
ViktorHofer
approved these changes
Jul 12, 2024
|
FYI @bartonjs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inbox implementation should no longer include a working binary formatter.
The check used to build a working formatter was '$(TargetFramework)' == '$(NetCoreAppMinimum)'.
Because NetCoreAppMinimum gets set to TargetFramework in the source-build configuration, the source-build configuration unintentionally included a working binary formatter.
Fixes #103683
@ViktorHofer ptal.