From 1cad22a8420bb26b87a535e21602d54096842a39 Mon Sep 17 00:00:00 2001 From: Noah Falk Date: Fri, 18 Oct 2024 00:58:16 -0700 Subject: [PATCH] Initialize m_fInPlaceSS A recent fix added a new field to the DebuggerPatchSkip object and missed initializing it false. This causes the new in-place patch skipping logic activate at random depending on the value of uninitialized memory. Fixing this by initializing the variable. --- src/coreclr/debug/ee/controller.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/coreclr/debug/ee/controller.cpp b/src/coreclr/debug/ee/controller.cpp index 2c72ee6642c2d7..fd26e7fe3135dd 100644 --- a/src/coreclr/debug/ee/controller.cpp +++ b/src/coreclr/debug/ee/controller.cpp @@ -4334,6 +4334,9 @@ DebuggerPatchSkip::DebuggerPatchSkip(Thread *thread, DebuggerControllerPatch *patch) : DebuggerController(thread, AppDomain::GetCurrentDomain()), m_address(patch->address) +#ifdef OUT_OF_PROCESS_SETTHREADCONTEXT + ,m_fInPlaceSS(false) +#endif { LOG((LF_CORDB, LL_INFO10000, "DPS::DPS: Patch skip 0x%p\n", patch->address));