add two SslStream tests for custom validation #38182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wfurt
added
area-System.Net.Security
test-enhancement
|
Tagging subscribers to this area: @dotnet/ncl |
bartonjs
reviewed
Jun 20, 2020
src/libraries/System.Net.Security/tests/FunctionalTests/TestHelper.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Jun 20, 2020
src/libraries/System.Net.Security/tests/FunctionalTests/TestHelper.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Jun 20, 2020
src/libraries/System.Net.Security/tests/FunctionalTests/TestHelper.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Jun 20, 2020
src/libraries/System.Net.Security/tests/FunctionalTests/TestHelper.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Jun 22, 2020
src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamNetworkStreamTest.cs
Show resolved
Hide resolved
bartonjs
reviewed
Jun 29, 2020
...libraries/Common/tests/System/Security/Cryptography/X509Certificates/CertificateAuthority.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Jun 29, 2020
...libraries/Common/tests/System/Security/Cryptography/X509Certificates/CertificateAuthority.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Jun 29, 2020
...libraries/Common/tests/System/Security/Cryptography/X509Certificates/CertificateAuthority.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Jun 29, 2020
...ystem.Security.Cryptography.X509Certificates/tests/RevocationTests/DynamicRevocationTests.cs
Show resolved
Hide resolved
bartonjs
reviewed
Jun 29, 2020
src/libraries/Common/tests/System/Security/Cryptography/X509Certificates/RevocationResponder.cs
Outdated
Show resolved
Hide resolved
bartonjs
approved these changes
Jul 1, 2020
This was referenced Jul 4, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PoC for something we discussed while back with @davidsh and @bartonjs.
The test helper generates chain of certificates on the fly and then we use them in the test.
That allows to inject properties or custom URLs to verify certain behaviors.
I don't know if there is better way to construct custom extensions. For example X509SubjectKeyIdentifierExtension is easy but to do same of issuer did not have helper.
The tests are somewhat simple. They both verify that the chain can be trusted but they return different result and then we verify the SSLStream behavior.
If we agree on this, I will write more interesting tests to cover some gaps I'm aware of.