From 45736f1ebed65c778c06ca290c1625b5f1578c26 Mon Sep 17 00:00:00 2001 From: Steve Pfister Date: Thu, 18 Nov 2021 21:57:52 -0500 Subject: [PATCH 1/2] Disable several failing tests on iOSSimulator arm64 A few tests popped up as failures on the rolling build due to parts of System.Diagnostics.Process throwing PNSE. Disabled the functional tests from running on arm64 as mlaunch can't detect the return code. --- .../tests/System/AppDomainTests.cs | 2 +- .../tests/System/EnvironmentTests.cs | 1 + src/libraries/tests.proj | 6 +++++- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs b/src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs index 2b8160cfa953e2..b6c83de69de1a6 100644 --- a/src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs +++ b/src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs @@ -379,7 +379,7 @@ public void ReflectionOnlyGetAssemblies() } [Fact] - [SkipOnPlatform(TestPlatforms.Browser, "Throws PNSE")] + [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS, "Throws PNSE")] public void MonitoringIsEnabled() { Assert.True(AppDomain.MonitoringIsEnabled); diff --git a/src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs b/src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs index 63723f0117a099..278898a6cfbd4e 100644 --- a/src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs +++ b/src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs @@ -96,6 +96,7 @@ public void ProcessPath_Idempotent() } [Fact] + [PlatformSpecific(~(TestPlatforms.iOS | TestPlatforms.tvOS))] public void ProcessPath_MatchesExpectedValue() { string expectedProcessPath = PlatformDetection.IsBrowser ? null : Process.GetCurrentProcess().MainModule.FileName; diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index ddc2ef5d1b610a..6dbb311329b342 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -166,7 +166,6 @@ - @@ -177,6 +176,11 @@ + + + + + From 8491563b14767632c2e4525e9e48412dbab04f09 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexander=20K=C3=B6plinger?= Date: Fri, 19 Nov 2021 12:44:58 +0100 Subject: [PATCH 2/2] Update src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs --- .../System.Runtime.Extensions/tests/System/EnvironmentTests.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs b/src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs index 278898a6cfbd4e..415cafb9f02c25 100644 --- a/src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs +++ b/src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs @@ -96,7 +96,7 @@ public void ProcessPath_Idempotent() } [Fact] - [PlatformSpecific(~(TestPlatforms.iOS | TestPlatforms.tvOS))] + [SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "Throws PNSE")] public void ProcessPath_MatchesExpectedValue() { string expectedProcessPath = PlatformDetection.IsBrowser ? null : Process.GetCurrentProcess().MainModule.FileName;