Skip to content

Conversation

@pavelsavara
Copy link
Member

-s ASSERTIONS=1 for debug build of runtime. It emits asserts to C and JS, it helps with debugging.

ASSERTIONS=1 is used to enable runtime checks for common memory allocation errors (e.g. writing more memory than was allocated). It also defines how Emscripten should handle errors in program flow. The value can be set to ASSERTIONS=2 in order to run additional #tests.

See https://emscripten.org/docs/porting/Debugging.html

@pavelsavara pavelsavara added this to the 7.0.0 milestone Dec 1, 2021
@ghost
Copy link

ghost commented Dec 1, 2021

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

-s ASSERTIONS=1 for debug build of runtime. It emits asserts to C and JS, it helps with debugging.

ASSERTIONS=1 is used to enable runtime checks for common memory allocation errors (e.g. writing more memory than was allocated). It also defines how Emscripten should handle errors in program flow. The value can be set to ASSERTIONS=2 in order to run additional #tests.

See https://emscripten.org/docs/porting/Debugging.html

Author: pavelsavara
Assignees: -
Labels:

arch-wasm, area-Infrastructure-mono

Milestone: 7.0.0

@radical
Copy link
Member

radical commented Dec 1, 2021

Related question - would it help, or make sense to enable this for AOT/library tests?

Copy link
Member

@kg kg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. I agree that we might want to enable it for AOT and/or library tests.

Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not until this doesn't break blazor

@ghost ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Dec 2, 2021
@lewing lewing added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Dec 2, 2021
@lewing
Copy link
Member

lewing commented Dec 2, 2021

see dotnet/aspnetcore#37690 and #55226

@ghost ghost added the no-recent-activity label Dec 16, 2021
@ghost
Copy link

ghost commented Dec 16, 2021

This pull request has been automatically marked no recent activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no recent activity.

@ghost
Copy link

ghost commented Dec 30, 2021

This pull request will now be closed since it had been marked no recent activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the pull request, but please note that it will be locked if it remains inactive for another 30 days.

@ghost ghost closed this Dec 30, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jan 29, 2022
@pavelsavara pavelsavara deleted the wasm_debug_emcc_asserts branch July 14, 2022 20:45
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-Build-mono needs-author-action An issue or pull request that requires more info or actions from the author. NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) no-recent-activity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants