Fix soundplayer assertion failure #62323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
buyaa-n
approved these changes
Dec 3, 2021
Contributor
buyaa-n
left a comment
buyaa-n
left a comment
There was a problem hiding this comment.
Removed assert. Verified that if loadSync is true, then _stream is non null, and add null forgiving operator.
Makes sense, thanks!
stephentoub
approved these changes
Dec 3, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #62305
Recent nullable annotations inadvertently added an invalid assert.
Removed assert. Verified that if
loadSyncis true, then_streamis non null, and add null forgiving operator.Verified all tests now pass including. outer loop