Fix SuperPMI unit test 'strip' behavior #62373
Conversation
In the case where replay of a test collection contains MISSING items, or other SuperPMI replay failures, we strip the failing method contexts from the result. This is very rare in the test scenario, but does happen mostly (presumably) due to SuperPMI tool bugs. However, the strip command wasn't actually being passed the set of things to strip, so it was just doing a straight copy. Thus, we ended up failing the "clean replay" because the failing MCs were still in the collection. The test has had this problem for a long time, and it looks like it has periodically hit in testing, but we haven't had bugs opened on these failures, so we haven't noticed.
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsIn the case where replay of a test collection contains MISSING items, The test has had this problem for a long time, and it looks like it has
|
|
@dotnet/jit-contrib PTAL |
|
ping |
2 participants
In the case where replay of a test collection contains MISSING items,
or other SuperPMI replay failures, we strip the failing method contexts
from the result. This is very rare in the test scenario, but does happen
mostly (presumably) due to SuperPMI tool bugs. However, the strip command
wasn't actually being passed the set of things to strip, so it was just
doing a straight copy. Thus, we ended up failing the "clean replay" because
the failing MCs were still in the collection.
The test has had this problem for a long time, and it looks like it has
periodically hit in testing, but we haven't had bugs opened on these failures,
so we haven't noticed.