Make test System.Data.Tests.AppDomainsAndFormatInfo.Bug55978 more robust #63028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @roji, @ajcvickers Issue DetailsBefore this change, the test would fail when current milliseconds are 0.
Example RowFilter I have added an explicit 1 minute to the tested datetime so the fractions of second don't play a role. Fixes #62898.
|
Member
Author
|
/azp run runtime-manual |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
@stephentoub I have found in the blame that you imported the code to this repository. The test method mentions a bug "55978" which I'm not able to track down. Do you have some idea what it could or whether the millisecond behavior in the test was intended? |
stephentoub
approved these changes
Jan 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the test would fail when current milliseconds are 0.
RowFilterhas only seconds, as it is a string.DateTimein rows have also fractions of second.RowFilterhave equality on both ends (>=and<=).RowFiltermatches 1 extra row.Example RowFilter
I have added an explicit 1 minute to the tested datetime so the fractions of second don't play a role.
Fixes #62965.