Remove some StringBuilderCache usage from Corelib #64522
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
src/libraries/System.Private.CoreLib/src/System/Globalization/TimeSpanParse.cs
Show resolved
Hide resolved
|
Tagging subscribers to this area: @dotnet/area-meta Issue Detailsnull
|
| case '\"': | ||
| StringBuilder enquotedString = StringBuilderCache.Acquire(); | ||
| if (!DateTimeParse.TryParseQuoteString(format, i, enquotedString, out tokenLen)) | ||
| var enquotedString = new ValueStringBuilder(32); |
There was a problem hiding this comment.
would it make sense to be slightly less conservative? 64?
src/libraries/System.Private.CoreLib/src/System/Globalization/TimeSpanParse.cs
Show resolved
Hide resolved
|
BTW, I noticed the comment higher up StreamWriter about #8890 The docs I've seen say that it's not guaranteed that stackallocs are zero inited - although the issue above implies we always do. Should we document that we do without SkipLocalsInit, and don't with SkipLocalsInit? Otherwise it's hard to reason about code. |
I don't believe SkipLocalsInit is relevant to that comment. It's talking about ref temporaries on the stack, which need to be zeroed even with SkipLocalsInit. |
ghost
locked as resolved and limited conversation to collaborators
2 participants
No description provided.