Deduplicate single-assembly vs. multi-assembly stringintern tests #64709
Conversation
ghost
assigned
|
Tagging subscribers to this area: @hoyosjs Issue DetailsThis is an interesting special example of deduplication where each of the tests (Test1, Test2, Test4) As the actual content of the test source code is the same in both cases and just Roslyn-compiles The tests were originally building in three flavors - "in-assembly", "cross-assembly" and "cross-module". Thanks Tomas /cc @dotnet/jit-contrib
|
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
2 participants
This is an interesting special example of deduplication where each of the tests (Test1, Test2, Test4)
runs alternatively in a single-assembly or multiple-assembly mode (compiled together with the
dependent source files teststr.cs / testgenstr.cs vs. using them via dependent projects
teststr.csproj / testgenstr.csproj).
As the actual content of the test source code is the same in both cases and just Roslyn-compiles
slightly differently based on the project structure, I have come to the conclusion that in this particular
case the least amount of churn can be achieved via a preprocessor define that is used to variate the
class name in the main test source files.
The tests were originally building in three flavors - "in-assembly", "cross-assembly" and "cross-module".
I have deleted the "cross-module" variants as I believe that they are identical to "cross-assembly".
Thanks
Tomas
/cc @dotnet/jit-contrib