From 39f5f7cb579a364e29acb9b7c642af98132bb924 Mon Sep 17 00:00:00 2001 From: Elinor Fung Date: Wed, 9 Feb 2022 16:43:42 -0800 Subject: [PATCH 1/2] Move test with expected crash to outerloop --- eng/testing/RunnerTemplate.sh | 6 +----- .../InteropServices/PosixSignalRegistrationTests.Unix.cs | 8 +++++++- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/eng/testing/RunnerTemplate.sh b/eng/testing/RunnerTemplate.sh index 839081e88fc70c..bfaa743ef6f414 100644 --- a/eng/testing/RunnerTemplate.sh +++ b/eng/testing/RunnerTemplate.sh @@ -132,11 +132,7 @@ if [[ "$(uname -s)" == "Darwin" ]]; then # files already in /cores/ at this point. This is being done to prevent # inadvertently flooding the CI machines with dumps. if [[ ! -d "/cores" || ! "$(ls -A /cores)" ]]; then - # TODO: Re-enable core dumps - https://github.com/dotnet/runtime/issues/65000 - # Temporarily disabling core dumps on osx as runtime work items uploading dumps - # are affecting the entire queue - # ulimit -c unlimited - ulimit -c 0 + ulimit -c unlimited fi elif [[ "$(uname -s)" == "Linux" ]]; then diff --git a/src/libraries/System.Runtime.InteropServices/tests/System.Runtime.InteropServices.UnitTests/System/Runtime/InteropServices/PosixSignalRegistrationTests.Unix.cs b/src/libraries/System.Runtime.InteropServices/tests/System.Runtime.InteropServices.UnitTests/System/Runtime/InteropServices/PosixSignalRegistrationTests.Unix.cs index f844b4d160a884..209d8c3ff05bd3 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System.Runtime.InteropServices.UnitTests/System/Runtime/InteropServices/PosixSignalRegistrationTests.Unix.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System.Runtime.InteropServices.UnitTests/System/Runtime/InteropServices/PosixSignalRegistrationTests.Unix.cs @@ -159,13 +159,19 @@ void CreateDanglingRegistration() } } + [ConditionalFact(nameof(NotMobileAndRemoteExecutable))] + [OuterLoop("SIGQUIT will generate a coredump")] + public void SignalCanCancelTermination_ExpectedCrash() + { + SignalCanCancelTermination(PosixSignal.SIGQUIT, false, 131); + } + [ConditionalTheory(nameof(NotMobileAndRemoteExecutable))] [InlineData(PosixSignal.SIGINT, true, 0)] [InlineData(PosixSignal.SIGINT, false, 130)] [InlineData(PosixSignal.SIGTERM, true, 0)] [InlineData(PosixSignal.SIGTERM, false, 143)] [InlineData(PosixSignal.SIGQUIT, true, 0)] - [InlineData(PosixSignal.SIGQUIT, false, 131)] public void SignalCanCancelTermination(PosixSignal signal, bool cancel, int expectedExitCode) { // Mono doesn't restore and call SIG_DFL on SIGQUIT. From deba647a982ee756a67c6807cb41de2e249323a4 Mon Sep 17 00:00:00 2001 From: Elinor Fung Date: Thu, 10 Feb 2022 12:27:03 -0800 Subject: [PATCH 2/2] Disable on OSX --- .../Runtime/InteropServices/PosixSignalRegistrationTests.Unix.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libraries/System.Runtime.InteropServices/tests/System.Runtime.InteropServices.UnitTests/System/Runtime/InteropServices/PosixSignalRegistrationTests.Unix.cs b/src/libraries/System.Runtime.InteropServices/tests/System.Runtime.InteropServices.UnitTests/System/Runtime/InteropServices/PosixSignalRegistrationTests.Unix.cs index 209d8c3ff05bd3..3ae21b3552f8af 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System.Runtime.InteropServices.UnitTests/System/Runtime/InteropServices/PosixSignalRegistrationTests.Unix.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System.Runtime.InteropServices.UnitTests/System/Runtime/InteropServices/PosixSignalRegistrationTests.Unix.cs @@ -161,6 +161,7 @@ void CreateDanglingRegistration() [ConditionalFact(nameof(NotMobileAndRemoteExecutable))] [OuterLoop("SIGQUIT will generate a coredump")] + [ActiveIssue("https://github.com/dotnet/runtime/issues/65000", TestPlatforms.OSX)] // large (~6 GB) coredump on OSX leads to timeout on upload public void SignalCanCancelTermination_ExpectedCrash() { SignalCanCancelTermination(PosixSignal.SIGQUIT, false, 131);