Skip to content

Move test with expected crash to outerloop #65114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2022
Merged

Move test with expected crash to outerloop #65114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39f5f7c
Move test with expected crash to outerloop
elinor-fung Feb 10, 2022
deba647
Disable on OSX
elinor-fung Feb 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions eng/testing/RunnerTemplate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,11 +132,7 @@ if [[ "$(uname -s)" == "Darwin" ]]; then
# files already in /cores/ at this point. This is being done to prevent
# inadvertently flooding the CI machines with dumps.
if [[ ! -d "/cores" || ! "$(ls -A /cores)" ]]; then
# TODO: Re-enable core dumps - https://github.com/dotnet/runtime/issues/65000
# Temporarily disabling core dumps on osx as runtime work items uploading dumps
# are affecting the entire queue
# ulimit -c unlimited
ulimit -c 0
ulimit -c unlimited
fi

elif [[ "$(uname -s)" == "Linux" ]]; then
Expand Down
9 changes: 8 additions & 1 deletion ...ropServices.UnitTests/System/Runtime/InteropServices/PosixSignalRegistrationTests.Unix.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,13 +159,20 @@ void CreateDanglingRegistration()
}
}

[ConditionalFact(nameof(NotMobileAndRemoteExecutable))]
[OuterLoop("SIGQUIT will generate a coredump")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/65000", TestPlatforms.OSX)] // large (~6 GB) coredump on OSX leads to timeout on upload
public void SignalCanCancelTermination_ExpectedCrash()
{
SignalCanCancelTermination(PosixSignal.SIGQUIT, false, 131);
}

[ConditionalTheory(nameof(NotMobileAndRemoteExecutable))]
[InlineData(PosixSignal.SIGINT, true, 0)]
[InlineData(PosixSignal.SIGINT, false, 130)]
[InlineData(PosixSignal.SIGTERM, true, 0)]
[InlineData(PosixSignal.SIGTERM, false, 143)]
[InlineData(PosixSignal.SIGQUIT, true, 0)]
[InlineData(PosixSignal.SIGQUIT, false, 131)]
public void SignalCanCancelTermination(PosixSignal signal, bool cancel, int expectedExitCode)
{
// Mono doesn't restore and call SIG_DFL on SIGQUIT.
Expand Down