Skip to content

Update Maui/Mobile pre.py's and disable android due to AOT Issue #65231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Feb 12, 2022
Merged

Update Maui/Mobile pre.py's and disable android due to AOT Issue #65231

merged 18 commits into from
Feb 12, 2022

Conversation

@LoopedBard3
Copy link
Member

@LoopedBard3 LoopedBard3 commented Feb 11, 2022

AOT Issue: dotnet/performance#2254
This will allow us to get iOS SOD and mono scenarios working again.
This also completes the proper updates for performance PR dotnet/performance#2259.

@LoopedBard3
Setup testing jobs, change repo to test perf repo, and added apk-name…
606c21b 
… parameter to pre.py for mobile scenarios.
@LoopedBard3
Update dotnet install type to be daily. This matches the link for ins…
e86f1d5 
…talling net 6.0 in the maui contributing dev requirements list.
@LoopedBard3
Try lowercase package name.
c5bd494
@LoopedBard3
List post build folder stuff.
84fc0e4
@LoopedBard3
Add android output format as apk.
00a8039
@LoopedBard3
Disable package replacement to see if that is the issue location.
31cffe7
@LoopedBard3
Revert "Disable package replacement to see if that is the issue locat…
c337f63 
…ion."

This reverts commit 31cffe7.
@LoopedBard3
Always try to publish the binlog files.
d7de05e
@LoopedBard3
Comment out the props file to see if that fixes the AOT error.
6f02eb4
@LoopedBard3
Readd props references.
c1cf860
@LoopedBard3
Try building without AOT.
45c0441
@LoopedBard3
Disable Maui Android Scenarios so that at least iOS on main are being…
e4dccdf 
… build and measured for SOD.
@LoopedBard3
Forgot to remove the uploading of the Android APP.
8ad4161
@LoopedBard3
Disable download attempt of the MauiAndroidApp.
db93c28
@LoopedBard3
Reenable full perf run.
d34f3a7
@LoopedBard3
Set the setup branch back to main.
ecc99ca
@LoopedBard3
Undisable MauiScenario.targets file. It semi-causes the AOT issue but…
d7ac6fd 
… should still be enabled for other working builds.
@LoopedBard3 LoopedBard3 self-assigned this Feb 11, 2022
@ghost
Copy link

ghost commented Feb 12, 2022

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

AOT Issue: dotnet/performance#2254
This will allow us to get iOS SOD and mono scenarios working again.
This also completes the proper updates for performance PR dotnet/performance#2259.

Author: LoopedBard3
Assignees: LoopedBard3
Labels:

area-Infrastructure-coreclr
Milestone: -

@DrewScoggins
Copy link
Member

DrewScoggins commented Feb 12, 2022

Does this PR still have testing stuff commented out?

@LoopedBard3 LoopedBard3 mentioned this pull request Feb 12, 2022
Merged
@LoopedBard3
Copy link
Member Author

LoopedBard3 commented Feb 12, 2022

No, double checking I made sure the commented-out stuff all pertains directly to disabling the Maui Android Scenario as a mitigation for the AOT error. The commented-out stuff is places the Maui apk is built, touches along getting to the machine, and the tests that run against it themselves.

DrewScoggins
DrewScoggins approved these changes Feb 12, 2022
View reviewed changes
Copy link
Member

@DrewScoggins DrewScoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, barring adding comments around the reason for commenting out blocks of code.

@LoopedBard3 LoopedBard3 merged commit a1f0147 into dotnet:main Feb 12, 2022
@LoopedBard3 LoopedBard3 deleted the UpdatePreForMobileForFileIndependence-runtime branch March 1, 2022 00:09
@ghost ghost locked as resolved and limited conversation to collaborators Mar 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DrewScoggins DrewScoggins DrewScoggins approved these changes

@Tohron Tohron Awaiting requested review from Tohron

Assignees

@LoopedBard3 LoopedBard3

Labels

area-Infrastructure-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LoopedBard3 @DrewScoggins