Resolve tvOS/iOS FileSystem test failures #74927
Conversation
non-Windows out of the app's working directory, which is readonly on some platforms. Closes: dotnet#67853
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsUse SetCurrentDirectory on tests which use an unrooted path on non-Windows out of the app's working directory, which is readonly on some platforms. Closes: #67853
|
|
Outstanding failures are unrelated infra, I think |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
carlossanlop
left a comment
carlossanlop
left a comment
There was a problem hiding this comment.
I see that you're wrapping some of those tests with a remote executor and adding the SetCurrentDirectory invocation at the beginning. I'd like to assume it's fine to do this in a remote executor context, because I worry that changing the current directory would affect the current process. But as long as that doesn't happen, we're ok.
I am also seeing that you're excluding tvos/ios/browser from the test platforms. I guess that is fine, because IIRC, remote executor does not work in any of those platforms.
@adamsitnik @jozkee I'm approving it but if you can take an extra look, that would be great.
adamsitnik
left a comment
adamsitnik
left a comment
There was a problem hiding this comment.
LGTM, thank you @directhex !
3 participants
Use SetCurrentDirectory on tests which use an unrooted path on non-Windows out of the app's working directory, which is readonly on some platforms.
Closes: #67853