Revert "[wasm] browser profiler (#77449)" #77759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0e24ea7. This breaks with v8 10.9.130 with: ``` Error: Invalid 'startMark' argument: No numeric 'startTime' field at pe (/home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:3:12994) at /home/helixbot/work/B2E7090F/w/A520093B/e/performance/artifacts/bin/for-running/MicroBenchmarks/659adab0-5c86-4e74-8913-672bd56fd58e/bin/net7.0/browser-wasm/AppBundle/dotnet.js:5:95874 exiting due to exception: Error: Invalid 'startMark' argument: No numeric 'startTime' field ``` It works fine with older versions like `10.7.193` (current stable).
radical
requested review from
BrzVlad,
SamMonoRT,
lambdageek,
lewing,
marek-safar,
pavelsavara,
thaystg and
vargaz
as code owners
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsThis reverts commit 0e24ea7. It broke all the perf pipeline wasm builds. It happens with v8 It works fine with older versions like
|
Member
Author
|
I'll open a separate PR to use the same version of V8 for all our testing on CI - #66164 . |
Member
Author
|
/azp run runtime-wasm-perf |
|
Azure Pipelines successfully started running 1 pipeline(s). |
radical
added
the
blocking-clean-ci
lambdageek
approved these changes
Nov 1, 2022
Member
Author
|
All the wasm jobs are passing. Merging this now to unblock CI. |
Member
|
thanks for this |
Member
|
It's interesting. They added the Here is another attempt #77779 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0e24ea7.
It broke all the perf pipeline wasm builds. It happens with v8
10.9.130:10.7.193(current stable).