Skip to content

Mono workloads: Fix building non-mono project when RunAOTCompilation=true #77762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 3, 2022
Merged

Mono workloads: Fix building non-mono project when RunAOTCompilation=true #77762

merged 2 commits into from
Nov 3, 2022

Conversation

@radical
Copy link
Member

@radical radical commented Nov 2, 2022 •
edited
Loading

This manifested in a case where a non-mono project was passed a mono specific property RunAOTCompilation=true, but instead of it getting ignored, the build failed with:

/usr/local/share/dotnet/sdk/7.0.200-preview.22521.7/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.ImportWorkloads.targets(38,5):

error NETSDK1147: To build this project, the following workloads must be installed: macos [/private/tmp/c/c.csproj]
error NETSDK1147: To install these workloads, run the following command: dotnet workload restore [/private/tmp/c/c.csproj]

And this is because the MonoAOTCompiler.Task is imported with:

runtime/src/mono/nuget/Microsoft.NET.Workload.Mono.Toolchain.Manifest/WorkloadManifest.targets.in

Line 57 in 82aa87f

<Import Condition="'$(TargetsCurrent)' == 'true' and '$(RunAOTCompilation)' == 'true' and '$(_BrowserWorkloadNotSupportedForTFM)' != 'true'" Project="Sdk.props" Sdk="Microsoft.NET.Runtime.MonoAOTCompiler.Task" />

  • This happens for net6, and net8 projects.

Fixes #77707 .

cc @steveisok @lewing

@radical
[wasm] WBT: Add tests for building non-wasm console project
a2091e9 
- with, and without workload
- with net6/7/8
- and with various mono specific properties set like
`RunAOTCompilation`, and `WasmBuildNative`.
@radical
[wasm] Fix building non-wasm projects with net6, and net8
bb1d63b 
.. when `RunAOTCompilation=true` is passed.
@radical radical requested a review from lewing as a code owner November 2, 2022 02:00
@ghost ghost assigned radical Nov 2, 2022
@radical radical added this to the 8.0.0 milestone Nov 2, 2022
@radical radical merged commit 8e45d5f into dotnet:main Nov 3, 2022
@radical radical deleted the fix-non-workload-builds branch November 3, 2022 15:41
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@steveisok steveisok steveisok approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger is a code owner

Assignees

@radical radical

Labels

area-Build-mono

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

Setting RunAOTCompilation=true on non-wasm/non-mobile projects fails to build

2 participants

@radical @steveisok