[mono] Fix support for generic custom attributes. #78091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 9, 2022
Member
|
Do we need a regression test? It would contribute to #73735. |
Contributor
Author
|
The test seems to fail on nativeaot. |
Member
Not completely surprised. This used to be a compiler crash until very late in RC1 when System.Reflection.Metadata finally fixed a bug around this leaving no runway in 7.0 to look at this. I added an ActiveIssue. |
This was referenced Nov 11, 2022
Member
|
Can we delete runtime/src/tests/issues.targets Line 1363 in 52eed7d |
vargaz
force-pushed
the
generic-cattr
branch
from
7dc7c29 to
f04481d
Compare
vargaz
force-pushed
the
generic-cattr
branch
2 times, most recently
from
134b49a to
ddfc910
Compare
Contributor
Author
|
Removed the added test and reenabled the existing ones. |
Contributor
Author
|
Failure is |
vargaz
force-pushed
the
generic-cattr
branch
from
ddfc910 to
28631d3
Compare
Member
|
|
vargaz
force-pushed
the
generic-cattr
branch
2 times, most recently
from
a0cd7e1 to
12eff9a
Compare
vargaz
force-pushed
the
generic-cattr
branch
from
12eff9a to
572f4c9
Compare
lewing
approved these changes
Nov 17, 2022
am11
approved these changes
Nov 17, 2022
Member
|
should we backport this? |
Contributor
Author
|
Its low risk. |
Contributor
|
If it's low risk then we should. |
Contributor
Author
|
It did seems to cause a small number of perf regressions: |
1 task
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77047.