diff --git a/Directory.Build.props b/Directory.Build.props index 9e8b408ef9af91..070c61866bedc4 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -130,7 +130,7 @@ $([MSBuild]::NormalizePath('$(MonoAOTCompilerDir)', 'MonoAOTCompiler.dll')) $([MSBuild]::NormalizePath('$(MonoTargetsTasksDir)', 'MonoTargetsTasks.dll')) $([MSBuild]::NormalizePath('$(TestExclusionListTasksDir)', 'TestExclusionListTasks.dll')) - $([MSBuild]::NormalizeDirectory('$(ArtifactsBinDir)', 'coreclr', '$(TargetOS).$(TargetArchitecture).$(Configuration)')) + $([MSBuild]::NormalizeDirectory('$(ArtifactsBinDir)', 'coreclr', '$(TargetOS).$(TargetArchitecture).$(RuntimeConfiguration)')) $(CoreCLRToolPath) $([MSBuild]::NormalizeDirectory($(ArtifactsObjDir), 'wasmtime')) @@ -151,11 +151,14 @@ + false true + <_hostRid Condition="'$(MSBuildRuntimeType)' == 'core'">$([System.Runtime.InteropServices.RuntimeInformation]::RuntimeIdentifier) + <_hostRid Condition="'$(MSBuildRuntimeType)' != 'core'">win-$([System.Runtime.InteropServices.RuntimeInformation]::OSArchitecture.ToString().ToLowerInvariant) + <_parseDistroRid>$(__DistroRid) - <_parseDistroRid Condition="'$(_parseDistroRid)' == '' and '$(MSBuildRuntimeType)' == 'core'">$([System.Runtime.InteropServices.RuntimeInformation]::RuntimeIdentifier) - <_parseDistroRid Condition="'$(_parseDistroRid)' == '' and '$(MSBuildRuntimeType)' != 'core'">win-$([System.Runtime.InteropServices.RuntimeInformation]::OSArchitecture.ToString().ToLowerInvariant) + <_parseDistroRid Condition="'$(_parseDistroRid)' == ''">$(_hostRid) <_distroRidIndex>$(_parseDistroRid.LastIndexOf('-')) <_runtimeOS>$(RuntimeOS) @@ -184,6 +187,7 @@ <_runtimeOS Condition="$(_runtimeOS.StartsWith('tizen'))">linux <_runtimeOS Condition="'$(PortableBuild)' == 'true'">$(_portableOS) + <_runtimeOS Condition="'$(RuntimeOS)' == '' and '$(DotNetBuildFromSource)' == 'true'">$(_portableOS) <_packageLibc Condition="$(_runtimeOS.Contains('musl'))">-musl <_packageOS Condition="'$(CrossBuild)' == 'true'">$(_hostOS)$(_packageLibc) @@ -216,6 +220,7 @@ $(_packageOS)-$(TargetArchitecture) + $(_hostRid) $(PackageRID) $(_portableOS)-$(TargetArchitecture) true @@ -258,6 +263,8 @@ + true + false true true @@ -324,7 +331,7 @@ portable true - + true false Properties diff --git a/eng/SourceBuild.props b/eng/SourceBuild.props index 4b4ba966025676..4f907f62538fd5 100644 --- a/eng/SourceBuild.props +++ b/eng/SourceBuild.props @@ -8,9 +8,6 @@ ./build.sh - true - false - $([System.Runtime.InteropServices.RuntimeInformation]::RuntimeIdentifier) $(__DistroRid) @@ -32,6 +29,9 @@ + $(InnerBuildArgs) --arch $(TargetArch) $(InnerBuildArgs) --configuration $(Configuration) $(InnerBuildArgs) --allconfigurations @@ -39,18 +39,10 @@ $(InnerBuildArgs) --nodereuse false $(InnerBuildArgs) --warnAsError false $(InnerBuildArgs) --outputrid $(TargetRid) - $(InnerBuildArgs) --portablebuild $(SourceBuildPortable) - $(InnerBuildArgs) /p:NoPgoOptimize=true - $(InnerBuildArgs) /p:KeepNativeSymbols=true $(InnerBuildArgs) /p:RuntimeOS=$(RuntimeOS) $(InnerBuildArgs) /p:OfficialBuildId=$(OfficialBuildId) $(InnerBuildArgs) /p:ContinuousIntegrationBuild=$(ContinuousIntegrationBuild) - $(InnerBuildArgs) /p:BuildDebPackage=false - $(InnerBuildArgs) /p:EnableNgenOptimization=false $(InnerBuildArgs) /p:AdditionalRuntimeIdentifierParent=$(BaseOS) - $(InnerBuildArgs) /p:EnablePackageValidation=false - - $(InnerBuildArgs) /p:ApiCompatValidateAssemblies=false $(InnerBuildArgs) /p:PrimaryRuntimeFlavor=Mono /p:RuntimeFlavor=Mono diff --git a/eng/packaging.targets b/eng/packaging.targets index e5cfa659cfaf97..d1fb653c6f928a 100644 --- a/eng/packaging.targets +++ b/eng/packaging.targets @@ -2,7 +2,9 @@ - true + true "TLS 1.0", SslProtocols.Tls11 => "TLS 1.1", +#pragma warning restore SYSLIB0039 SslProtocols.Tls12 => "TLS 1.2", #if !NETFRAMEWORK SslProtocols.Tls13 => "TLS 1.3", @@ -491,6 +493,7 @@ private static bool AndroidGetSslProtocolSupport(SslProtocols protocol) return (protocol & s_androidSupportedSslProtocols.Value) == protocol; } +#pragma warning disable SYSLIB0039 // TLS versions 1.0 and 1.1 have known vulnerabilities private static bool GetTls10Support() { // on macOS and Android TLS 1.0 is supported. @@ -529,6 +532,7 @@ private static bool GetTls11Support() return OpenSslGetTlsSupport(SslProtocols.Tls11); } +#pragma warning restore SYSLIB0039 private static bool GetTls12Support() { diff --git a/src/libraries/Common/tests/TestUtilities/System/WindowsIdentityFixture.cs b/src/libraries/Common/tests/TestUtilities/System/WindowsIdentityFixture.cs index ae5a86b1e74203..0f0ff0c2cce1e2 100644 --- a/src/libraries/Common/tests/TestUtilities/System/WindowsIdentityFixture.cs +++ b/src/libraries/Common/tests/TestUtilities/System/WindowsIdentityFixture.cs @@ -118,8 +118,8 @@ private void CreateUser() [return: MarshalAs(UnmanagedType.Bool)] private static partial bool LogonUser(string userName, string domain, string password, int logonType, int logonProvider, out SafeAccessTokenHandle safeAccessTokenHandle); - [LibraryImport("netapi32.dll", SetLastError = true)] - internal static partial uint NetUserAdd([MarshalAs(UnmanagedType.LPWStr)] string servername, uint level, ref USER_INFO_1 buf, out uint parm_err); + [DllImport("netapi32.dll", SetLastError = true)] + internal static extern uint NetUserAdd([MarshalAs(UnmanagedType.LPWStr)] string servername, uint level, ref USER_INFO_1 buf, out uint parm_err); [LibraryImport("netapi32.dll")] internal static partial uint NetUserDel([MarshalAs(UnmanagedType.LPWStr)] string servername, [MarshalAs(UnmanagedType.LPWStr)] string username); diff --git a/src/libraries/Microsoft.NETCore.Platforms/tests/Microsoft.NETCore.Platforms.Tests.csproj b/src/libraries/Microsoft.NETCore.Platforms/tests/Microsoft.NETCore.Platforms.Tests.csproj index 2622635380116f..d4b11af0a96d6a 100644 --- a/src/libraries/Microsoft.NETCore.Platforms/tests/Microsoft.NETCore.Platforms.Tests.csproj +++ b/src/libraries/Microsoft.NETCore.Platforms/tests/Microsoft.NETCore.Platforms.Tests.csproj @@ -1,6 +1,6 @@ - $(NetCoreAppCurrent);net472 + $(NetCoreAppCurrent);$(NetFrameworkToolCurrent) true diff --git a/src/tests/Directory.Build.props b/src/tests/Directory.Build.props index d09ffadace18e9..437d976fa78b37 100644 --- a/src/tests/Directory.Build.props +++ b/src/tests/Directory.Build.props @@ -74,7 +74,6 @@ coreclr false - true false