Skip to content

Fix precondition if HOST_UNIX in ClrVirtualAllocWithinRange() #84023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2023
Merged

Fix precondition if HOST_UNIX in ClrVirtualAllocWithinRange() #84023

merged 1 commit into from
Mar 28, 2023

Conversation

@k15tfu
Copy link
Contributor

@k15tfu k15tfu commented Mar 28, 2023

Fixes #83818

@ghost ghost added area-VM-coreclr community-contribution Indicates that the PR has been added by a community member labels Mar 28, 2023
@k15tfu k15tfu mentioned this pull request Mar 28, 2023
Merged
@k15tfu k15tfu force-pushed the fix-issue-83818-precond branch from 7395191 to adc5cf1 Compare March 28, 2023 14:41
@k15tfu
Copy link
Contributor Author

k15tfu commented Mar 28, 2023

Addresses comments from #83958.

jkotas
jkotas approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

janvorli
janvorli approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@jkotas
Copy link
Member

jkotas commented Mar 28, 2023

The failure is #84010

@jkotas jkotas merged commit dc75cd8 into dotnet:main Mar 28, 2023
@k15tfu k15tfu deleted the fix-issue-83818-precond branch March 29, 2023 04:52
@ghost ghost locked as resolved and limited conversation to collaborators Apr 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotas jkotas jkotas approved these changes

@janvorli janvorli janvorli approved these changes

Assignees

No one assigned

Labels

area-VM-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

System.OutOfMemoryException when allocating jump stub on macOS ARM64

3 participants

@k15tfu @jkotas @janvorli