Ensure we use bytes, not bits

[tannergooding]

This resolves #85543

[ghost]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

---

null

Author:	tannergooding
Assignees:	tannergooding
Labels:	area-CodeGen-coreclr
Milestone:	-

[sebastienros]

/benchmark fortunes_ef aspnet-citrine-win runtime

[pr-benchmarks]

Benchmark started for fortunes_ef on aspnet-citrine-win with runtime. Logs: link

[tannergooding]

Local results.

Show a change from | Requests/sec | 1,142,312 | to | Requests/sec | 1,221,836 |

Before:

crank --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/scenarios/platform.benchmarks.yml --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/build/azure.profile.yml --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/build/ci.profile.yml --scenario json --profile intel-lin-app --profile intel-load2-load --application.framework net8.0 --application.collectDependencies true --application.options.collectCounters true --application.aspNetCoreVersion 8.0.0-preview.5.23268.15 --application.runtimeVersion 8.0.0-preview.5.23268.13 --application.sdkVersion 8.0.100-preview.5.23269.2

application
CPU Usage (%)	99
Cores usage (%)	2,782
Working Set (MB)	97
Private Memory (MB)	629
Build Time (ms)	7,544
Start Time (ms)	176
Published Size (KB)	96,437
Symbols Size (KB)	53
.NET Core SDK Version	8.0.100-preview.5.23269.2
ASP.NET Core Version	8.0.0-preview.5.23268.15+631f523
.NET Runtime Version	8.0.0-preview.5.23268.13+51d467a
Max CPU Usage (%)	100
Max Working Set (MB)	102
Max GC Heap Size (MB)	33
Size of committed memory by the GC (MB)	0
Max Number of Gen 0 GCs / sec	0.00
Max Number of Gen 1 GCs / sec	0.00
Max Number of Gen 2 GCs / sec	0.00
Max Time in GC (%)	0.00
Max Gen 0 Size (B)	0
Max Gen 1 Size (B)	0
Max Gen 2 Size (B)	0
Max LOH Size (B)	0
Max POH Size (B)	0
Max Allocation Rate (B/sec)	12,657,728
Max GC Heap Fragmentation	0
# of Assemblies Loaded	68
Max Exceptions (#/s)	834
Max Lock Contention (#/s)	120
Max ThreadPool Threads Count	48
Max ThreadPool Queue Length	279
Max ThreadPool Items (#/s)	1,258,882
Max Active Timers	1
IL Jitted (B)	182,308
Methods Jitted	1,949

load
CPU Usage (%)	77
Cores usage (%)	2,163
Working Set (MB)	48
Private Memory (MB)	363
Start Time (ms)	0
First Request (ms)	127
Requests/sec	1,142,312
Requests	17,248,747
Mean latency (ms)	0.63
Max latency (ms)	36.71
Bad responses	0
Socket errors	0
Read throughput (MB/s)	159.05
Latency 50th (ms)	0.41
Latency 75th (ms)	0.48
Latency 90th (ms)	0.55
Latency 99th (ms)	7.96

After

crank --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/scenarios/platform.benchmarks.yml --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/build/azure.profile.yml --config https://raw.githubusercontent.com/aspnet/Benchmarks/main/build/ci.profile.yml --scenario json --profile intel-lin-app --profile intel-load2-load --application.framework net8.0 --application.collectDependencies true --application.options.collectCounters true --application.aspNetCoreVersion 8.0.0-preview.5.23268.15 --application.runtimeVersion 8.0.0-preview.5.23268.13 --application.sdkVersion 8.0.100-preview.5.23269.2 --application.options.outputFiles C:\Users\tagoo\source\repos\runtime2\artifacts\tests\coreclr\windows.x64.Release\*.*

application
CPU Usage (%)	99
Cores usage (%)	2,774
Working Set (MB)	98
Private Memory (MB)	630
Build Time (ms)	3,486
Start Time (ms)	191
Published Size (KB)	96,437
Symbols Size (KB)	53
.NET Core SDK Version	8.0.100-preview.5.23269.2
ASP.NET Core Version	8.0.0-preview.5.23268.15+631f523
.NET Runtime Version	8.0.0-preview.5.23268.13+51d467a
Max CPU Usage (%)	99
Max Working Set (MB)	102
Max GC Heap Size (MB)	33
Size of committed memory by the GC (MB)	0
Max Number of Gen 0 GCs / sec	0.00
Max Number of Gen 1 GCs / sec	0.00
Max Number of Gen 2 GCs / sec	0.00
Max Time in GC (%)	0.00
Max Gen 0 Size (B)	0
Max Gen 1 Size (B)	0
Max Gen 2 Size (B)	0
Max LOH Size (B)	0
Max POH Size (B)	0
Max Allocation Rate (B/sec)	16,159,584
Max GC Heap Fragmentation	0
# of Assemblies Loaded	68
Max Exceptions (#/s)	850
Max Lock Contention (#/s)	147
Max ThreadPool Threads Count	48
Max ThreadPool Queue Length	249
Max ThreadPool Items (#/s)	1,355,179
Max Active Timers	1
IL Jitted (B)	182,377
Methods Jitted	1,954

load
CPU Usage (%)	80
Cores usage (%)	2,237
Working Set (MB)	48
Private Memory (MB)	363
Start Time (ms)	0
First Request (ms)	125
Requests/sec	1,221,836
Requests	18,449,371
Mean latency (ms)	0.53
Max latency (ms)	48.99
Bad responses	0
Socket errors	0
Read throughput (MB/s)	170.12
Latency 50th (ms)	0.38
Latency 75th (ms)	0.44
Latency 90th (ms)	0.51
Latency 99th (ms)	6.01

[sebastienros]

Results for Fortunes EF from the bot:

| application           | fortunes_ef.base          | fortunes_ef.pr            |         |
| --------------------- | ------------------------- | ------------------------- | ------- |
| CPU Usage (%)         |                        91 |                        91 |   0.00% |
| Cores usage (%)       |                     2,544 |                     2,537 |  -0.28% |
| Working Set (MB)      |                       583 |                       661 | +13.38% |
| Private Memory (MB)   |                       599 |                       677 | +13.02% |
| Build Time (ms)       |                     3,225 |                     3,252 |  +0.84% |
| Start Time (ms)       |                     1,962 |                     1,876 |  -4.38% |
| Published Size (KB)   |                    98,605 |                    98,605 |   0.00% |
| Symbols Size (KB)     |                        54 |                        54 |   0.00% |
| .NET Core SDK Version | 8.0.100-preview.5.23269.8 | 8.0.100-preview.5.23269.8 |         |


| load                   | fortunes_ef.base | fortunes_ef.pr |          |
| ---------------------- | ---------------- | -------------- | -------- |
| CPU Usage (%)          |               33 |             35 |   +6.06% |
| Cores usage (%)        |              917 |            991 |   +8.07% |
| Working Set (MB)       |               48 |             48 |    0.00% |
| Private Memory (MB)    |              363 |            363 |    0.00% |
| Start Time (ms)        |                0 |              0 |          |
| First Request (ms)     |              783 |            787 |   +0.51% |
| Requests/sec           |          360,460 |        399,394 |  +10.80% |
| Requests               |        5,442,859 |      6,030,775 |  +10.80% |
| Mean latency (ms)      |             1.51 |           1.41 |   -6.62% |
| Max latency (ms)       |            55.25 |         157.32 | +184.74% |
| Bad responses          |                0 |              0 |          |
| Socket errors          |                0 |              0 |          |
| Read throughput (MB/s) |           474.05 |         525.25 |  +10.80% |
| Latency 50th (ms)      |             1.32 |           1.20 |   -9.09% |
| Latency 75th (ms)      |             1.59 |           1.44 |   -9.43% |
| Latency 90th (ms)      |             2.10 |           1.88 |  -10.48% |
| Latency 99th (ms)      |             6.19 |           6.99 |  +12.92% |