[wasm] Re-enable ~6700 runtime tests that got disabled mistakenly #86747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radical
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing Issue Detailsnull
|
- These were all getting removed because it looked for the incorrect script path in case of wasm
``` Operation is not supported on this platform. at System.Threading.Thread.ThrowIfNoThreadStart(Boolean internalThread) at System.Threading.Thread.Start(Boolean captureContext, Boolean internalThread) at System.Threading.Thread.Start() at MutualThdRecur_fptr.main() at Program.<>c__DisplayClass0_0.<<Main>$>g__TestExecutor29|30(TestFilter filter, StreamWriter tempLogSw, StreamWriter statsCsvSw) ```
radical
force-pushed
the
wasm-runtime-tests
branch
from
d383458 to
cfd2073
Compare
radical
changed the title
lewing
approved these changes
May 25, 2023
`JIT/Performance/CodeQuality/Benchstones/MDBenchI/MDPuzzle/` dotnet#86772
|
The coreclr failure is known, and unrelated to this PR. |
|
@radical Sorry for the trouble, and thanks for making the fix (fwiw, I was on vacation so didn't see this when you requested a review) |
no worries! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix running merged test wrappers for runtime tests:
Issue - there are ~6700 fewer tests running.
The reason is that all the new merged test wrappers get removed from running because they are looking for the incorrect run script in case of wasm.
This got disabled by: