JIT: add missing recursive tail call detection logic #93892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now require that recursive tail calls be noted before morph by setting method and block flags. Add missing flag setting when devirtualization creates a recursive tail call candidate. Also add a diagnosic post-phase check to catch cases like this earlier. Fixes dotnet#93844.
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsWe now require that recursive tail calls be noted before morph by setting method and block flags. Add missing flag setting when devirtualization creates a recursive tail call candidate. Also add a diagnosic post-phase check to catch cases like this earlier. Fixes #93844.
|
Member
Author
|
cc @dotnet/jit-contrib |
Member
Author
|
/azp run runtime-coreclr libraries-jitstress, runtime-coreclr jitstress |
|
Azure Pipelines successfully started running 2 pipeline(s). |
jakobbotsch
approved these changes
Oct 23, 2023
Member
Author
|
Failures may be #91769 ? |
Member
|
They look known according to build analysis (#48798) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now require that recursive tail calls be noted before morph by setting method and block flags. Add missing flag setting when devirtualization creates a recursive tail call candidate.
Also add a diagnosic post-phase check to catch cases like this earlier.
Fixes #93844.