Skip to content

Reduce process count for ETW manifest test #96950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Reduce process count for ETW manifest test #96950

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc4f152
Reduce process count for ETW manifest test
AaronRobinsonMSFT Jan 14, 2024
2bcccf4
Use nameof for string.
AaronRobinsonMSFT Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
151 changes: 73 additions & 78 deletions ...ries/System.Diagnostics.Tracing/tests/BasicEventSourceTest/TestsManifestGeneration.Etw.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,117 +33,112 @@ public partial class TestsManifestGeneration
[SkipOnCoreClr("Test should only be run in non-stress modes", ~RuntimeTestModes.RegularRun)]
public void Test_EventSource_EtwManifestGeneration()
{
RemoteInvokeOptions options = new RemoteInvokeOptions { TimeOut = 300_000 /* ms */ };
RemoteExecutor.Invoke(() =>
{
RemoteInvokeOptions localOptions = new RemoteInvokeOptions { TimeOut = 300_000 /* ms */ };
using (RemoteInvokeHandle handle = RemoteExecutor.Invoke(() =>
{
var es = new SimpleEventSource();
for (var i = 0; i < 100; i++)
{
es.WriteSimpleInt(i);
Thread.Sleep(100);
}
}, localOptions))
{
var etlFileName = @"file.etl";
var tracesession = new TraceEventSession("testname", etlFileName);
var pid = Process.GetCurrentProcess().Id;
var etlFileName = $"file.{pid}.etl";
var tracesession = new TraceEventSession("testname", etlFileName);

tracesession.EnableProvider("SimpleEventSource");
tracesession.EnableProvider(nameof(SimpleEventSource));

Thread.Sleep(TimeSpan.FromSeconds(5));
RemoteInvokeOptions localOptions = new RemoteInvokeOptions { TimeOut = 300_000 /* ms */ };
using (RemoteInvokeHandle handle = RemoteExecutor.Invoke(() =>
{
var es = new SimpleEventSource();
for (var i = 0; i < 100; i++)
{
es.WriteSimpleInt(i);
Thread.Sleep(100);
}
}, localOptions))
{
Thread.Sleep(TimeSpan.FromSeconds(5));

tracesession.Flush();
tracesession.Flush();

tracesession.DisableProvider("SimpleEventSource");
tracesession.Dispose();
tracesession.DisableProvider(nameof(SimpleEventSource));
tracesession.Dispose();

var manifestExists = false;
var max_retries = 50;
var manifestExists = false;
var max_retries = 50;

for (int i = 0; i < max_retries; i++)
for (int i = 0; i < max_retries; i++)
{
if (VerifyManifestAndRemoveFile(etlFileName))
{
if (VerifyManifestAndRemoveFile(etlFileName))
{
manifestExists = true;
break;
}
Thread.Sleep(1000);
manifestExists = true;
break;
}
Assert.True(manifestExists);
Thread.Sleep(1000);
}
}, options).Dispose();
Assert.True(manifestExists);
}
}

[ConditionalFact(nameof(IsProcessElevatedAndNotWindowsNanoServerAndRemoteExecutorSupported))]
[SkipOnCoreClr("Test should only be run in non-stress modes", ~RuntimeTestModes.RegularRun)]
public void Test_EventSource_EtwManifestGenerationRollover()
{
RemoteExecutor.Invoke(() =>
{
using (RemoteInvokeHandle handle = RemoteExecutor.Invoke(() =>
{
var es = new SimpleEventSource();
for (var i = 0; i < 100; i++)
{
es.WriteSimpleInt(i);
Thread.Sleep(100);
}
}))
{
var initialFileName = @"initialFile.etl";
var rolloverFileName = @"rolloverFile.etl";
var tracesession = new TraceEventSession("testname", initialFileName);
var max_retries = 50;
var pid = Process.GetCurrentProcess().Id;
var initialFileName = $"initialFile.{pid}.etl";
var rolloverFileName = $"rolloverFile.{pid}.etl";
var tracesession = new TraceEventSession("testname", initialFileName);

tracesession.EnableProvider("SimpleEventSource");
tracesession.EnableProvider(nameof(SimpleEventSource));

Thread.Sleep(TimeSpan.FromSeconds(5));
using (RemoteInvokeHandle handle = RemoteExecutor.Invoke(() =>
{
var es = new SimpleEventSource();
for (var i = 0; i < 100; i++)
{
es.WriteSimpleInt(i);
Thread.Sleep(100);
}
}))
{
Thread.Sleep(TimeSpan.FromSeconds(5));

tracesession.Flush();
tracesession.Flush();

tracesession.SetFileName(rolloverFileName);
tracesession.SetFileName(rolloverFileName);

Thread.Sleep(TimeSpan.FromSeconds(5));
Thread.Sleep(TimeSpan.FromSeconds(5));

tracesession.Flush();
tracesession.Flush();

tracesession.DisableProvider("SimpleEventSource");
tracesession.Dispose();
tracesession.DisableProvider(nameof(SimpleEventSource));
tracesession.Dispose();

bool initialFileHasManifest = false;
bool rollOverFileHasManifest = false;
bool initialFileHasManifest = false;
bool rollOverFileHasManifest = false;

for (int i = 0; i < max_retries; i++)
var max_retries = 50;
for (int i = 0; i < max_retries; i++)
{
if (VerifyManifestAndRemoveFile(initialFileName))
{
if (VerifyManifestAndRemoveFile(initialFileName))
{
initialFileHasManifest = true;
break;
}
Thread.Sleep(1000);
initialFileHasManifest = true;
break;
}
for (int i = 0; i < max_retries; i++)
Thread.Sleep(1000);
}
for (int i = 0; i < max_retries; i++)
{
if (VerifyManifestAndRemoveFile(rolloverFileName))
{
if (VerifyManifestAndRemoveFile(rolloverFileName))
{
rollOverFileHasManifest = true;
break;
}
Thread.Sleep(1000);
rollOverFileHasManifest = true;
break;
}
Assert.True(initialFileHasManifest);
Assert.True(rollOverFileHasManifest);
Thread.Sleep(1000);
}
}).Dispose();
Assert.True(initialFileHasManifest);
Assert.True(rollOverFileHasManifest);
}
}

private bool VerifyManifestAndRemoveFile(string fileName)
{
Assert.True(File.Exists(fileName));

ETWTraceEventSource source = new ETWTraceEventSource(fileName);
using var source = new ETWTraceEventSource(fileName);

Dictionary<string, int> providers = new Dictionary<string, int>();
int eventCount = 0;
Expand All @@ -157,7 +152,7 @@ private bool VerifyManifestAndRemoveFile(string fileName)
}
providers[eventData.ProviderName]++;

if (eventData.ProviderName.Equals("SimpleEventSource") && eventData.EventName.Equals("ManifestData"))
if (eventData.ProviderName.Equals(nameof(SimpleEventSource)) && eventData.EventName.Equals("ManifestData"))
{
sawManifestData = true;
}
Expand All @@ -167,7 +162,7 @@ private bool VerifyManifestAndRemoveFile(string fileName)

if (!sawManifestData)
{
Console.WriteLine("Did not see ManifestData event from SimpleEventSource, test will fail. Additional info:");
Console.WriteLine($"Did not see ManifestData event from {nameof(SimpleEventSource)}, test will fail. Additional info:");
Console.WriteLine($" file name {fileName}");
Console.WriteLine($" total event count {eventCount}");
Console.WriteLine($" total providers {providers.Count}");
Expand Down