Use internationally viable formatting for dates used in, for example, file paths (#46745)

Fixes #46727
Fixes #37932
(@MiYanni commented that it looks similar to the issue I'd been looking at. Turns out 46727 is a dupe, but since I have a PR out already, I'll leave them up and close both via this.)

This replaces culture-sensitive ToString calls on DateTime.Now with string.Create(CultureInfo.InvariantCulture, $"[{DateTime.Now:yyyyMMdd}]") (or equivalent). This had been used in a file path and errored when using certain calendars.

Author: Forgind

src/Cli/dotnet/Installer/Windows/TimestampedFileLogger.cs

@@ -2,6 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using System.Collections.Concurrent;
+using System.Globalization;
 using System.IO.Pipes;
 using System.Runtime.Versioning;
 
@@ -42,7 +43,7 @@ public string LogPath
         /// <summary>
         /// The locale-neutral timestamp prefix.
         /// </summary>
-        protected static string TimeStamp => $"[{DateTime.Now:yyyy-MM-dd HH:mm:ss.fff}]";
+        protected static string TimeStamp => $"[{string.Create(CultureInfo.InvariantCulture, $"{DateTime.Now:yyyy-MM-dd HH:mm:ss.fff}")}]";
 
         /// <summary>
         /// Creates a new <see cref="TimestampedFileLogger"/> instance.

src/Cli/dotnet/commands/dotnet-workload/install/NetSdkMsiInstallerClient.cs

@@ -1,7 +1,9 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
+using System.Globalization;
 using System.Linq;
+using System.Runtime.CompilerServices;
 using System.Runtime.Versioning;
 using System.Text.Json;
 using Microsoft.DotNet.Cli;
@@ -1125,7 +1127,7 @@ public static NetSdkMsiInstallerClient Create(
             bool shouldLog = true)
         {
             ISynchronizingLogger logger =
-                shouldLog ? new TimestampedFileLogger(Path.Combine(Path.GetTempPath(), $"Microsoft.NET.Workload_{Environment.ProcessId}_{DateTime.Now:yyyyMMdd_HHmmss_fff}.log"))
+                shouldLog ? new TimestampedFileLogger(Path.Combine(Path.GetTempPath(), string.Create(CultureInfo.InvariantCulture, $"Microsoft.NET.Workload_{Environment.ProcessId}_{DateTime.Now:yyyyMMdd_HHmmss_fff}.log")))
                           : new NullInstallerLogger();
             InstallClientElevationContext elevationContext = new(logger);