Update AOT test #27334
Merged
Update AOT test #27334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
sbomer
reviewed
Aug 23, 2022
src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAnAotApp.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAnAotApp.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAnAotApp.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAnAotApp.cs
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAnAotApp.cs
Show resolved
Hide resolved
sbomer
approved these changes
Aug 30, 2022
Member
sbomer
left a comment
sbomer
left a comment
There was a problem hiding this comment.
A few more suggestions, otherwise LGTM. Thanks!
src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAnAotApp.cs
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAnAotApp.cs
Show resolved
Hide resolved
LakshanF
added a commit
to LakshanF/sdk
that referenced
this pull request
Aug 30, 2022
* Update AO test * Fix typo in AotNoValidRuntimePackageError * Apply suggestions from code review Co-authored-by: Sven Boemer <[email protected]> * FB * fix test * FB Co-authored-by: Sven Boemer <[email protected]>
LakshanF
added a commit
that referenced
this pull request
Aug 31, 2022
* Update AO test * Fix typo in AotNoValidRuntimePackageError * Apply suggestions from code review Co-authored-by: Sven Boemer <[email protected]> * FB * fix test * FB Co-authored-by: Sven Boemer <[email protected]> Co-authored-by: Sven Boemer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A resource typo fix + Removed explicit package references for cross-target publishing when PublishAOT is set to true since the SDK will download all the required
ILCompilerpackages (one build and 2 runtime - host and target - packages)This test will not pass until the corresponding runtime changes are merged with this branch.