Handle new warnings

Author: ThomasGoulet73

eng/WpfArcadeSdk/tools/CodeAnalysis/CodeAnalysis.src.globalconfig

@@ -297,7 +297,7 @@ dotnet_diagnostic.CA1820.severity = none
 dotnet_diagnostic.CA1821.severity = none # TODO: warning
 
 # CA1822: Mark members as static
-dotnet_diagnostic.CA1822.severity = warning
+dotnet_diagnostic.CA1822.severity = none # TODO: warning
 dotnet_code_quality.CA1822.api_surface = private, internal
 
 # CA1823: Avoid unused private fields
@@ -388,7 +388,7 @@ dotnet_diagnostic.CA1850.severity = warning
 dotnet_diagnostic.CA1851.severity = suggestion
 
 # CA1852: Seal internal types
-dotnet_diagnostic.CA1852.severity = warning
+dotnet_diagnostic.CA1852.severity = none # TODO: warning
 
 # CA1853: Unnecessary call to 'Dictionary.ContainsKey(key)'
 dotnet_diagnostic.CA1853.severity =  warning

src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Windows/Markup/StaticExtensionConverter.cs

@@ -18,7 +18,9 @@
 
 namespace System.Windows.Markup
 {
+#pragma warning disable CA1812 // This type is used inside a TypeConverterAttribute which creates instances of this class.
     class StaticExtensionConverter : TypeConverter
+#pragma warning restore CA1812
     {
         public override bool CanConvertTo(ITypeDescriptorContext context, Type destinationType)
         {

src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Windows/Markup/TypeExtensionConverter.cs

@@ -18,7 +18,9 @@
 
 namespace System.Windows.Markup
 {
+#pragma warning disable CA1812 // This type is used inside a TypeConverterAttribute which creates instances of this class.
     class TypeExtensionConverter : TypeConverter
+#pragma warning restore CA1812
     {
         public override bool CanConvertTo(ITypeDescriptorContext context, Type destinationType)
         {

src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/Schema/XamlTypeInvoker.cs

@@ -346,28 +346,5 @@ private static bool EnsureConstructorDelegate(XamlTypeInvoker type)
                 return true;
             }
         }
-
-        private class UnknownTypeInvoker : XamlTypeInvoker
-        {
-            public override void AddToCollection(object instance, object item)
-            {
-                throw new NotSupportedException(SR.NotSupportedOnUnknownType);
-            }
-
-            public override void AddToDictionary(object instance, object key, object item)
-            {
-                throw new NotSupportedException(SR.NotSupportedOnUnknownType);
-            }
-
-            public override object CreateInstance(object[] arguments)
-            {
-                throw new NotSupportedException(SR.NotSupportedOnUnknownType);
-            }
-
-            public override IEnumerator GetItems(object instance)
-            {
-                throw new NotSupportedException(SR.NotSupportedOnUnknownType);
-            }
-        }
     }
 }

src/Microsoft.DotNet.Wpf/src/System.Xaml/System/Xaml/XamlType.cs

@@ -1511,7 +1511,7 @@ private static string GetTypeName(Type type)
                 // save the subscript
                 string subscript;
                 typeName = GenericTypeNameScanner.StripSubscript(typeName, out subscript);
-                typeName = typeName.Substring(0, index) + subscript;
+                typeName = string.Concat(typeName.AsSpan(0, index), subscript);
             }
             // if nested, add the containing name
             if (type.IsNested)