Use Microsoft.CodeAnalysis.NetAnalyzers #7395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
ghost
requested review from
ThomasGoulet73
changed the title
Member
|
@ThomasGoulet73 , this PR looks good to me. And we want to take it in the upcoming CTP. I saw WinForms did a change - dotnet/winforms#8947. Do we need to include this fix in this PR? |
dipeshmsft
approved these changes
Jun 28, 2023
Member
|
@ThomasGoulet73, I have merged the PR and as mentioned in the previous comment, we can take up other fixes in a different PR. Thanks a lot for this contribution. This will help us a lot in improving the code base. |
Contributor
Author
|
Thank you @dipeshmsft. Sorry I missed your comment, I'll try to take a look at it soon. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #2033
Inspired by dotnet/winforms#7035
Description
Use Microsoft.CodeAnalysis.NetAnalyzers instead of Microsoft.CodeAnalysis.FxCopAnalyzers.
In commit 7d47015 I disabled rules that required verbose changes and I fixed a couple of new warnings.
Customer Impact
None.
Regression
No.
Testing
Local build + CI.
Risk
Low.
Microsoft Reviewers: Open in CodeFlow