[Testing] Integrating System.Xaml.Tests with build flow #7976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
dipeshmsft
added
the
* NO MERGE *
hughbe
reviewed
Jul 5, 2023
| } | ||
|
|
||
| [Fact] | ||
| public void GetHashCode_NullContentWrapper_ThrowsNullReferenceException() |
Contributor
There was a problem hiding this comment.
nit: rename to "GetHashCode_NullContentWrapper_ReturnsZero"
hughbe
reviewed
Jul 5, 2023
| Assert.Throws<ArgumentException>(null, () => ValueSerializer.GetSerializerFor(type)); | ||
| Assert.Throws<ArgumentException>(null, () => ValueSerializer.GetSerializerFor(type, null)); | ||
| } | ||
| // [Theory] |
Member
Author
|
Closing this PR now as #8013 is created. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!! NO MERGE !!
Main PR
#138
Description
This PR is to test the integration of tests written in #138 with the build flow of WPF. The aim here is to understand the changes required to run the tests on the pipeline. Once, we verify that tests run are running on pipeline, this PR will be closed.
Customer Impact
Provides the team with relevant information to setup test infra for running unit tests on pipeline.
Regression
--
Testing
Built and ran the tests locally using
.\build.cmd -testcommandRisk
Microsoft Reviewers: Open in CodeFlow