no-streaming flag in logs

[marekott]

Hi, recently I was investigating logs generated by Yarp because we have noticed that entries informing about proxying of the request always ends with no-streaming. Our first thought was that it indicates that request was buffered in memory before proxying it to destination service. However after further investigation, I can see that this flag is only informing if current request was made with gRpc (https://github.com/microsoft/reverse-proxy/blob/main/src/ReverseProxy/Forwarder/HttpForwarder.cs#L135). Why is this info so important that it is added to each of those logs especially that it will change its value only when gRpc call is made? It can be a little misleading since streaming can be performed also in other scenarios than gRpc (WebSockets for example).

[Tratcher]

Also filed as a discussion: #2193

[karelz]

It currently covers only gRPC, but might cover more in future.
We could just drop the negative "no-streaming" parameter from logging and keep only the positive one "streaming".
We should also update gRPC docs to clarify it.

[marekott]

Hi @karelz sounds like a better solution than the current one. Of course perfect situation would be if it would cover more than only gRPC scenario. I can see that you have added help wanted label, I could help with that but please confirm that we indeed are removing no-streaming log and keep only streaming for gRPC.

[karelz]

Yes, that is correct.

[marekott]

Made PR with that change: #2200. Hope it will be useful.