test(phpstan): Enable PHPstan level 5 (#1123)

Author: klausi

phpstan.neon

@@ -8,7 +8,7 @@ parameters:
 	# PHPStan cannot find files in this test directory automatically.
 	scanDirectories:
 		- ../../core/tests/Drupal/Tests
-	level: 4
+	level: 5
 	customRulesetUsed: true
 	paths:
 		- .
@@ -30,6 +30,8 @@ parameters:
 		- "#deprecated class Symfony\\\\Component\\\\HttpKernel\\\\Event\\\\GetResponseEvent#"
 		- "#^Method Symfony\\\\Contracts\\\\EventDispatcher\\\\EventDispatcherInterface\\:\\:dispatch\\(\\) invoked with 2 parameters, 1 required\\.$#"
 		- "#deprecated interface Symfony\\\\Component\\\\HttpFoundation\\\\File\\\\MimeType\\\\MimeTypeGuesserInterface#"
+		- "#^Parameter .+ of class Symfony\\\\Component\\\\HttpFoundation\\\\File\\\\UploadedFile constructor expects .+ given\\.$#"
+		- "#^Parameter \\#1 \\$event of method Symfony\\\\Contracts\\\\EventDispatcher\\\\EventDispatcherInterface\\:\\:dispatch\\(\\) expects object, string given\\.$#"
 		# Drupal allows object property access to custom fields, so we cannot fix
 		# that.
 		- "#^Property Drupal\\\\.+ \\(Drupal\\\\Core\\\\Field\\\\FieldItemListInterface\\) does not accept .+\\.$#"
@@ -38,3 +40,4 @@ parameters:
 			message: "#^Method Drupal\\\\graphql\\\\Plugin\\\\LanguageNegotiation\\\\OperationLanguageNegotiation\\:\\:getLangcode\\(\\) should return string but returns false\\.$#"
 			count: 1
 			path: src/Plugin/LanguageNegotiation/OperationLanguageNegotiation.php
+		- "#^Parameter .+ of method Drupal\\\\Core\\\\Entity\\\\Query\\\\QueryInterface\\:\\:range\\(\\) expects null, int given\\.$#"

src/GraphQL/Buffers/EntityBuffer.php

@@ -28,7 +28,7 @@ public function __construct(EntityTypeManagerInterface $entityTypeManager) {
    *
    * @param string $type
    *   The entity type of the given entity ids.
-   * @param array|int $id
+   * @param array|int|string $id
    *   The entity id(s) to load.
    *
    * @return \Closure

tests/src/Kernel/Framework/UploadFileServiceTest.php

@@ -222,7 +222,8 @@ public function testLockReleased() {
   protected function getUploadedFile(
     int $error_status,
     int $size = 0,
-    string $name = 'test.txt'): UploadedFile {
+    string $name = 'test.txt'
+  ): UploadedFile {
 
     list($version) = explode('.', \Drupal::VERSION, 2);
     switch ($version) {

tests/src/Traits/HttpRequestTrait.php

@@ -57,7 +57,7 @@ protected function query($query, $server = NULL, array $variables = [], array $e
   /**
    * Simulate batched queries over http.
    *
-   * @param string[] $queries
+   * @param array[] $queries
    *   A set of queries to be executed in one go.
    * @param \Drupal\graphql\Entity\ServerInterface $server
    *   The server instance.

tests/src/Traits/QueryResultAssertionTrait.php

@@ -161,7 +161,7 @@ private function assertResultErrors(ExecutionResult $result, array $expected) {
     while ($error = array_pop($errors)) {
       $match = FALSE;
       foreach ($expected as $pattern) {
-        if (@preg_match($pattern, NULL) === FALSE) {
+        if (@preg_match($pattern, $error) === FALSE) {
           $match = $match || $pattern == $error;
           $matchCount[$pattern]++;
         }