#737 Add cache context to response_cache_contexts in plugin definition for ContextDeriver, if available #865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 31, 2019 19:52
…ugin definition for ContextDeriver
…ugin definition for ContextDeriver, if available.
fubhy
requested changes
Jul 31, 2019
modules/graphql_core/src/Plugin/Deriver/Fields/ContextDeriver.php
Outdated
Show resolved
Hide resolved
…ugin definition for ContextDervier, no overwrite.
Codecov Report
@@ Coverage Diff @@
## 8.x-3.x #865 +/- ##
=============================================
+ Coverage 79.57% 79.61% +0.04%
- Complexity 1277 1278 +1
=============================================
Files 192 192
Lines 3177 3179 +2
=============================================
+ Hits 2528 2531 +3
+ Misses 649 648 -1
Continue to review full report at Codecov.
|
Contributor
|
Great, will merge once tests results come back in :-). Thanks! |
fubhy
approved these changes
Jul 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the cache context to the deriver, if available.