fix: simplify paths logic

Author: 43081j

build/main.js

@@ -24383,21 +24383,23 @@ var visitorKeys = [
   ["peerDependency", "peerDependencies"],
   ["optionalDependency", "optionalDependencies"]
 ];
-function traverseInternal(node, visitor, parentMap) {
+function traverseInternal(node, visitor, path2) {
   for (const [visitorKey, nodeKey] of visitorKeys) {
     if (visitor[visitorKey]) {
+      const newPath = [...path2, node];
       for (const dep of node[nodeKey]) {
-        parentMap.set(dep, node);
-        if (visitor[visitorKey](dep, node, parentMap) !== false) {
-          traverseInternal(dep, visitor, parentMap);
+        if (path2.includes(dep)) {
+          continue;
+        }
+        if (visitor[visitorKey](dep, node, newPath) !== false) {
+          traverseInternal(dep, visitor, newPath);
         }
       }
     }
   }
 }
 function traverse(node, visitor) {
-  const parentMap = /* @__PURE__ */ new WeakMap();
-  return traverseInternal(node, visitor, parentMap);
+  return traverseInternal(node, visitor, []);
 }
 
 // node_modules/lockparse/lib/main.js
@@ -24859,36 +24861,18 @@ function getLsCommand(lockfilePath, packageName) {
   }
   return void 0;
 }
-function getParentPath(node, parentMap) {
-  const parentPath = [];
-  if (!parentMap) {
-    return parentPath;
-  }
-  const seen = /* @__PURE__ */ new WeakSet();
-  let currentParent = parentMap.get(node);
-  while (currentParent) {
-    parentPath.push(`${currentParent.name}@${currentParent.version}`);
-    if (seen.has(currentParent)) {
-      parentPath.push("(circular)");
-      break;
-    }
-    seen.add(currentParent);
-    currentParent = parentMap.get(currentParent);
-  }
-  return parentPath;
-}
 function computeParentPaths(lockfile, duplicateDependencyNames, dependencyMap) {
   const parentPaths = /* @__PURE__ */ new Map();
-  const visitorFn = (node, _parent, parentMap) => {
-    if (!duplicateDependencyNames.has(node.name)) {
+  const visitorFn = (node, _parent, path2) => {
+    if (!duplicateDependencyNames.has(node.name) || !path2) {
       return;
     }
     const versionSet = dependencyMap.get(node.name);
     if (!versionSet) {
       return;
     }
-    const parentPath = getParentPath(node, parentMap);
-    parentPaths.set(`${node.name}@${node.version}`, parentPath.join(" -> "));
+    const parentPath = path2.map((node2) => `${node2.name}@${node2.version}`).join(" -> ");
+    parentPaths.set(`${node.name}@${node.version}`, parentPath);
   };
   const visitor = {
     dependency: visitorFn,

package-lock.json

@@ -44,7 +44,7 @@
     "@types/node": "^24.9.0",
     "esbuild": "^0.25.11",
     "eslint": "^9.38.0",
-    "lockparse": "^0.4.0",
+    "lockparse": "^0.5.0",
     "module-replacements": "^2.9.0",
     "pkg-types": "^2.3.0",
     "prettier": "^3.6.2",

package.json

@@ -1,4 +1,9 @@
-import {type ParsedLockFile, traverse, type ParsedDependency} from 'lockparse';
+import {
+  type ParsedLockFile,
+  traverse,
+  type ParsedDependency,
+  type VisitorFn
+} from 'lockparse';
 
 function getLsCommand(
   lockfilePath: string,
@@ -19,49 +24,25 @@ function getLsCommand(
   return undefined;
 }
 
-function getParentPath(
-  node: ParsedDependency,
-  parentMap: WeakMap<ParsedDependency, ParsedDependency> | undefined
-): string[] {
-  const parentPath: string[] = [];
-  if (!parentMap) {
-    return parentPath;
-  }
-  const seen = new WeakSet<ParsedDependency>();
-  let currentParent = parentMap.get(node);
-  while (currentParent) {
-    parentPath.push(`${currentParent.name}@${currentParent.version}`);
-    if (seen.has(currentParent)) {
-      parentPath.push('(circular)');
-      break;
-    }
-    seen.add(currentParent);
-    currentParent = parentMap.get(currentParent);
-  }
-  return parentPath;
-}
-
 function computeParentPaths(
   lockfile: ParsedLockFile,
   duplicateDependencyNames: Set<string>,
   dependencyMap: Map<string, Set<string>>
 ): Map<string, string> {
   const parentPaths = new Map<string, string>();
 
-  const visitorFn = (
-    node: ParsedDependency,
-    _parent: ParsedDependency | null,
-    parentMap?: WeakMap<ParsedDependency, ParsedDependency>
-  ) => {
-    if (!duplicateDependencyNames.has(node.name)) {
+  const visitorFn: VisitorFn = (node, _parent, path) => {
+    if (!duplicateDependencyNames.has(node.name) || !path) {
       return;
     }
     const versionSet = dependencyMap.get(node.name);
     if (!versionSet) {
       return;
     }
-    const parentPath = getParentPath(node, parentMap);
-    parentPaths.set(`${node.name}@${node.version}`, parentPath.join(' -> '));
+    const parentPath = path
+      .map((node) => `${node.name}@${node.version}`)
+      .join(' -> ');
+    parentPaths.set(`${node.name}@${node.version}`, parentPath);
   };
   const visitor = {
     dependency: visitorFn,