From 4dcdf4c84e0006e87b6b8158febf2daffb6486dd Mon Sep 17 00:00:00 2001 From: Wouter Deconinck Date: Wed, 29 Oct 2025 11:57:49 -0500 Subject: [PATCH 1/2] feat: add Truthiness datatype for Monte Carlo comparisons --- edm4eic.yaml | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/edm4eic.yaml b/edm4eic.yaml index dfaa144..e1c2e4c 100644 --- a/edm4eic.yaml +++ b/edm4eic.yaml @@ -540,7 +540,7 @@ datatypes: - edm4eic::ReconstructedParticle hadrons // Reconstructed hadrons used in calculation ## ========================================================================== - ## Data-Montecarlo relations + ## Data-Monte Carlo relations ## ========================================================================== edm4eic::MCRecoParticleAssociation: @@ -623,6 +623,32 @@ datatypes: - edm4eic::Track from // reference to the track - edm4eic::ProtoCluster to // reference to the protocluster + ## ========================================================================== + ## Data-Monte Carlo comparisons + ## ========================================================================== + + edm4eic::Truthiness: + Description: "Positive-definite convex norm of how confidently wrong the reconstruction is, + with non-negative contributions from various aspects of the reconstruction, + where a zero value indicates a perfect reconstruction." + Author: "W. Deconinck, S. Colbert" + Members: + - float event_truthiness // Overall truthiness of the entire event + - float event_pid_contribution // Contribution of PID matching to truthiness + - float event_energy_contribution // Contribution of energy matching to truthiness + - float event_momentum_contribution // Contribution of momentum matching to truthiness + - float unassociated_mc_particles_contribution // Contribution from unassociated MC particles + - float unassociated_rc_particles_contribution // Contribution from unassociated reconstructed particles + VectorMembers: + - float association_truthiness // Overall truthiness of each association + - float association_pid_contribution // Contribution of PID matching to truthiness + - float association_energy_contribution // Contribution of energy matching to truthiness + - float association_momentum_contribution // Contribution of momentum matching to truthiness + OneToManyRelations: + - edm4eic::MCRecoParticleAssociation associations // Reference to the associated reconstructed particles + - edm4hep::MCParticle unassociated_mc_particles // Reference to the unassociated MC particles + - edm4eic::ReconstructedParticle unassociated_rc_particles // Reference to the unassociated reconstructed particles + links: edm4eic::TrackProtoClusterLink: Description: "Link between a ProtoCluster and a Track" From b397bf9a77c6b621c38e247bd330932baafbdac0 Mon Sep 17 00:00:00 2001 From: Wouter Deconinck Date: Thu, 6 Nov 2025 15:31:49 -0600 Subject: [PATCH 2/2] =?UTF-8?q?CamelCase=20=F0=9F=90=AA=F0=9F=90=AB?= =?UTF-8?q?=F0=9F=90=AB=F0=9F=90=AB=F0=9F=90=AB=F0=9F=90=AB=F0=9F=90=AB?= =?UTF-8?q?=F0=9F=90=AB=20(starting=20with=20dromedary)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- edm4eic.yaml | 28 +++++++++++++++------------- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/edm4eic.yaml b/edm4eic.yaml index e1c2e4c..39b0fdc 100644 --- a/edm4eic.yaml +++ b/edm4eic.yaml @@ -200,6 +200,13 @@ components: - bool TOTInProgress // Flag which indicates if TOT calculation is ongoing, ADC value may be corrupted if this is true - bool TOTComplete // Flag which indicates if a TOT calculation is complete and TOT value is valid + ## Event-level truthiness information + edm4eic::TruthinessContribution: + Members: + - float pid // Contribution of PID matching to truthiness + - float energy // Contribution of energy matching to truthiness + - float momentum // Contribution of momentum matching to truthiness + datatypes: edm4eic::Tensor: @@ -633,21 +640,16 @@ datatypes: where a zero value indicates a perfect reconstruction." Author: "W. Deconinck, S. Colbert" Members: - - float event_truthiness // Overall truthiness of the entire event - - float event_pid_contribution // Contribution of PID matching to truthiness - - float event_energy_contribution // Contribution of energy matching to truthiness - - float event_momentum_contribution // Contribution of momentum matching to truthiness - - float unassociated_mc_particles_contribution // Contribution from unassociated MC particles - - float unassociated_rc_particles_contribution // Contribution from unassociated reconstructed particles + - float truthiness // Overall truthiness of the entire event + - edm4eic::TruthinessContribution associationContribution // Contribution from all associated particles + - float unassociatedMCParticlesContribution // Contribution from unassociated MC particles + - float unassociatedRecoParticlesContribution // Contribution from unassociated reconstructed particles VectorMembers: - - float association_truthiness // Overall truthiness of each association - - float association_pid_contribution // Contribution of PID matching to truthiness - - float association_energy_contribution // Contribution of energy matching to truthiness - - float association_momentum_contribution // Contribution of momentum matching to truthiness + - edm4eic::TruthinessContribution associationContributions // Contribution from associated particles OneToManyRelations: - - edm4eic::MCRecoParticleAssociation associations // Reference to the associated reconstructed particles - - edm4hep::MCParticle unassociated_mc_particles // Reference to the unassociated MC particles - - edm4eic::ReconstructedParticle unassociated_rc_particles // Reference to the unassociated reconstructed particles + - edm4eic::MCRecoParticleAssociation associations // Reference to the associated particles + - edm4hep::MCParticle unassociatedMCParticles // Reference to the unassociated MC particles + - edm4eic::ReconstructedParticle unassociatedRecoParticles // Reference to the unassociated reconstructed particles links: edm4eic::TrackProtoClusterLink: