Revert to original state to investigate clang-tidy warnings

Co-authored-by: wdconinc <[email protected]>

Author: Copilot

.clang-tidy

@@ -9,6 +9,7 @@ Checks: '
   -bugprone-easily-swappable-parameters,
   -bugprone-macro-parentheses,
   -bugprone-narrowing-conversions,
+
   -modernize-use-trailing-return-type,
   -modernize-avoid-c-arrays,
   -modernize-use-nodiscard,

src/algorithms/tracking/ActsToTracks.cc

@@ -97,11 +97,6 @@ void ActsToTracks::process(const Input& input, const Output& output) const {
       // Get the fitted track parameter
       const auto& boundParam = traj->trackParameters(trackTip);
       const auto& parameter  = boundParam.parameters();
-
-      if (!boundParam.covariance()) {
-        warning("No covariance matrix for trajectory with entry index = {}", trackTip);
-        continue;
-      }
       const auto& covariance = *boundParam.covariance();
 
       auto pars = track_parameters->create();

src/algorithms/tracking/TrackProjector.cc

@@ -95,17 +95,7 @@ void TrackProjector::process(const Input& input, const Output& output) const {
       }
 
       // get track state bound parameters and their boundCovs
-#if Acts_VERSION_MAJOR >= 36
-      if (!trackstate.predicted()) {
-        return; // skip this track state if no predicted parameters
-      }
-#endif
       const auto& boundParams = trackstate.predicted();
-#if Acts_VERSION_MAJOR >= 36
-      if (!trackstate.predictedCovariance()) {
-        return; // skip this track state if no predicted covariance
-      }
-#endif
       const auto& boundCov    = trackstate.predictedCovariance();
 
       // convert local to global

src/algorithms/tracking/TrackPropagation.cc

@@ -267,19 +267,7 @@ TrackPropagation::propagate(const edm4eic::Track& /* track */,
   // For last measurement surface, filtered and smoothed results are equivalent
   auto trackState        = mj.getTrackState(trackTip);
   auto initSurface       = trackState.referenceSurface().getSharedPtr();
-#if Acts_VERSION_MAJOR >= 36
-  if (!trackState.filtered()) {
-    m_log->trace("    no filtered parameters available");
-    return nullptr;
-  }
-#endif
   const auto& initParams = trackState.filtered();
-#if Acts_VERSION_MAJOR >= 36
-  if (!trackState.filteredCovariance()) {
-    m_log->trace("    no filtered covariance available");
-    return nullptr;
-  }
-#endif
   const auto& initCov    = trackState.filteredCovariance();
 
   Acts::BoundTrackParameters initBoundParams(initSurface, initParams, initCov,
@@ -328,17 +316,8 @@ TrackPropagation::propagate(const edm4eic::Track& /* track */,
   m_log->trace("    propagation result is OK");
 
   // Pulling results to convenient variables
-  if (!(*result).endParameters) {
-    m_log->trace("    propagation failed (no endParameters)");
-    return nullptr;
-  }
-  auto trackStateParams  = *(*result).endParameters;
+  auto trackStateParams  = *((*result).endParameters);
   const auto& parameter  = trackStateParams.parameters();
-  
-  if (!trackStateParams.covariance()) {
-    m_log->trace("    propagation failed (no covariance)");
-    return nullptr;
-  }
   const auto& covariance = *trackStateParams.covariance();
 
   // Path length

src/benchmarks/reconstruction/tracking_efficiency/TrackingEfficiency_processor.cc

@@ -108,11 +108,6 @@ void TrackingEfficiency_processor::Process(const std::shared_ptr<const JEvent>&
     if (traj->hasTrackParameters(trackTip)) {
       const auto& boundParam = traj->trackParameters(trackTip);
       const auto& parameter  = boundParam.parameters();
-
-      if (!boundParam.covariance()) {
-        m_log->debug("No covariance available for track parameters");
-        continue;
-      }
       const auto& covariance = *boundParam.covariance();
       m_log->debug("{:>10.2f} {:>10.2f}  {:>10.2f} {:>10.3f} {:>10.4f} {:>10.3f} {:>12.4e} "
                    "{:>12.4e} {:>12.4e} {:>8.2f}",