Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Jun 19, 2025

Motivation/summary

the default tracer is leaking and its background goroutine spamming requests to this apm server (default endpoint) If TLS is enabled it causes 'http request sent to https endpoint'.

Close the default tracer since it's not used.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

  • run apm-server with tls enabled
  • enable self instrumentation
  • check the message is not logged on startup

Related issues


This is an automatic backport of pull request #17293 done by [Mergify](https://mergify.com).

the default tracer is leaking and its background goroutine
spamming requests to this apm server (default endpoint)
If TLS is enabled it causes 'http request sent to https endpoint'.

Close the default tracer since it's not used.

(cherry picked from commit 26c5c56)
@mergify mergify bot added the backport label Jun 19, 2025
@mergify mergify bot requested a review from a team as a code owner June 19, 2025 12:13
@mergify mergify bot mentioned this pull request Jun 19, 2025
2 tasks
@mergify mergify bot merged commit faaf395 into 8.18 Jun 19, 2025
16 checks passed
@mergify mergify bot deleted the mergify/bp/8.18/pr-17293 branch June 19, 2025 12:26
@kruskall kruskall mentioned this pull request Jun 23, 2025
4 tasks
@endorama
Copy link
Contributor

I tested with 8.18.3 BC1 and I got this log line printed:

{"log.level":"error","@timestamp":"2025-06-23T11:19:38.136Z","log.logger":"beater.http","log.origin":{"function":"net/http.(*Server).logf","file.name":"http/server.go","file.line":3638},"message":"http: TLS handshake error from [::1]:36942: client sent an HTTP request to an HTTPS server","service.name":"apm-server","ecs.version":"1.6.0"}

The same message does not appear if auto instrumentation is set to off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants