Skip to content

Conversation

@marclop
Copy link
Contributor

@marclop marclop commented Dec 21, 2021

Motivation/summary

Adds the missing mapping for transaction.name to logs-apm.error.

Checklist

- [ ] Update CHANGELOG.asciidoc
- [ ] Update package changelog.yml (only if changes to apmpackage have been made)
- [ ] Documentation has been updated

How to test these changes

  1. docker-compose up -d
  2. cd systemtest && go test -v -run TestErrorIngest .
  3. Navigate to Kibana > Dev tools
GET logs-apm.error*/_search
{
  "query": {
    "exists": {
      "field": "transaction.name"
    }
  }, 
  "_source": [false], 
  "fields": [
    "transaction.type",
    "transaction.name"
  ]
}

Verify that the query returns a result with the transaction.name set.

Related issues

Fixes regression found in #6539

Adds the missing mapping for `transaction.name` to `logs-apm.error`.

Signed-off-by: Marc Lopez Rubio <[email protected]>
@ghost
Copy link

ghost commented Dec 21, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-22T08:43:44.190+0000

  • Duration: 41 min 56 sec

  • Commit: 29a4359

Test stats 🧪

Test Results
Failed 0
Passed 5617
Skipped 19
Total 5636

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /hey-apm : Run the hey-apm benchmark.

  • /package : Generate and publish the docker images.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Signed-off-by: Marc Lopez Rubio <[email protected]>
@marclop marclop requested a review from a team December 21, 2021 06:24
@simitt
Copy link
Contributor

simitt commented Dec 22, 2021

Please release a new apmpackage to staging when merging this.

@marclop marclop merged commit 43850ef into elastic:master Dec 23, 2021
@marclop marclop deleted the b/fix-logs-apm.error-transaction.name-mapping branch December 23, 2021 01:39
@marclop marclop added the backport-8.0 Automated backport with mergify label Dec 23, 2021
mergify bot pushed a commit that referenced this pull request Dec 23, 2021
Adds the missing mapping for `transaction.name` to `logs-apm.error`.

(cherry picked from commit 43850ef)
marclop pushed a commit that referenced this pull request Dec 23, 2021
Adds the missing mapping for `transaction.name` to `logs-apm.error`.

(cherry picked from commit 43850ef)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.0 Automated backport with mergify bug v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants