Skip to content

Commit 4097695

Browse files
committed
Add debug logging when packaging with EXTERNAL=true
1 parent aa2afc0 commit 4097695

File tree

1 file changed

+17
-1
lines changed

1 file changed

+17
-1
lines changed

magefile.go

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1057,6 +1057,10 @@ func collectPackageDependencies(platforms []string, packageVersion string, packa
10571057

10581058
if devtools.ExternalBuild == true {
10591059

1060+
if mg.Verbose() {
1061+
log.Print(">>> Using external builds to collect components")
1062+
}
1063+
10601064
// Only log fatal logs for logs produced. This is the global logger
10611065
// used by github.com/elastic/elastic-agent/dev-tools/mage/downloads which can only be configured globally like this.
10621066
//
@@ -1070,17 +1074,29 @@ func collectPackageDependencies(platforms []string, packageVersion string, packa
10701074
completedDownloads := &atomic.Int32{}
10711075
for _, spec := range packaging.ExpectedBinaries {
10721076
for _, platform := range platforms {
1077+
10731078
if !spec.SupportsPlatform(platform) {
1074-
fmt.Printf("--- Binary %s does not support %s, download skipped\n", spec.BinaryName, platform)
1079+
log.Printf(">>> Binary %s does not support %s, download skipped\n", spec.BinaryName, platform)
10751080
continue
10761081
}
1082+
1083+
if mg.Verbose() {
1084+
log.Printf(">>> Looking for component %s/%s", spec.BinaryName, platform)
1085+
}
10771086
for _, pkgType := range packageTypes {
1087+
if mg.Verbose() {
1088+
log.Printf(">>> Evaluating pkgType %v for component %s/%s", pkgType, spec.BinaryName, platform)
1089+
}
10781090
if !spec.SupportsPackageType(pkgcommon.PackageType(pkgType)) {
1091+
log.Printf(">>> PkgType %v for component %s/%s not supported. Skipping...", pkgType, spec.BinaryName, platform)
10791092
continue
10801093
}
10811094
targetPath := filepath.Join(archivePath, manifest.PlatformPackages[platform])
10821095
os.MkdirAll(targetPath, 0o755)
10831096
packageName := spec.GetPackageName(packageVersion, platform)
1097+
if mg.Verbose() {
1098+
log.Printf(">>> Downloading package %s component %s/%s", packageName, spec.BinaryName, platform)
1099+
}
10841100
errGroup.Go(downloadBinary(ctx, spec.ProjectName, packageName, spec.BinaryName, platform, packageVersion, targetPath, completedDownloads))
10851101
}
10861102
}

0 commit comments

Comments
 (0)