Low level client update (#974)

* new transport

* fix multibufferentity

* client builder refactor

* temp

* temp

* temp

* original tests

* new tests

* fixing tests

* flatten low level client folder structure

* Move things around, remove duplicated tests

* naming refactor

* Add ElasticsearchTestClient that randomly chooses an implementation

* regen from latest spec

* test fixes

* esql test config fix

* porting low level client unit tests

* low level client tests to junit 5

* Randomize client implementation, remove cloud-id on Rest5, add tests for overloaded methods

* Refine client builder

* todos and timeouts fix

* checkstyle fixes

* remove maven local + remove legacy test

* Add insecure SSLContext

* temp rebase fix

* Reduce public API surface

* Extract HttpRequest.Node (future-proof this class for later use)

* Remove Node.boundHosts: it's mostly useless in the container era

* Port RestClient's sniffer to Rest5Client

* Move Node back to its original location. TransportHttpClient is self-contained

* Refactor client builder to transport configuration

* Allow extensions of ElasticsearchTransportConfig

* Remove calls to AccessController which is deprecated for removal

* Fix licenseReport

* Revert "temp rebase fix"

This reverts commit 48f2b57.

* [codegen] update to latest spec and generator

* fixing tests

* regen

---------

Co-authored-by: Sylvain Wallez <[email protected]>

Author: l-trotta

example-transports/src/test/java/co/elastic/clients/transport/rest_client/RestTransportClientTest.java

@@ -20,20 +20,21 @@
 package co.elastic.clients.transport.rest_client;
 
 import co.elastic.clients.transport.TransportHttpClientTest;
+import co.elastic.clients.transport.rest5_client.Rest5ClientHttpClient;
 import org.apache.http.HttpHost;
 import org.elasticsearch.client.RestClient;
 
-public class RestTransportClientTest extends TransportHttpClientTest<RestClientHttpClient> {
+public class RestTransportClientTest extends TransportHttpClientTest<Rest5ClientHttpClient> {
 
     public RestTransportClientTest() {
         super(createClient());
     }
 
-    private static RestClientHttpClient createClient() {
+    private static Rest5ClientHttpClient createClient() {
         RestClient restClient = RestClient.builder(
             new HttpHost(server.getAddress().getAddress(), server.getAddress().getPort(), "http")
         ).build();
 
-        return new RestClientHttpClient(restClient);
+        return new Rest5ClientHttpClient(restClient);
     }
 }

java-client/build.gradle.kts

@@ -38,8 +38,8 @@ checkstyle {
 }
 
 java {
-    targetCompatibility = JavaVersion.VERSION_1_8
-    sourceCompatibility = JavaVersion.VERSION_1_8
+    targetCompatibility = JavaVersion.VERSION_17
+    sourceCompatibility = JavaVersion.VERSION_17
 
     withJavadocJar()
     withSourcesJar()
@@ -200,14 +200,16 @@ signing {
 dependencies {
     // Compile and test with the last 7.x version to make sure transition scenarios where
     // the Java API client coexists with a 7.x HLRC work fine
-    val elasticsearchVersion = "8.10.0"
+    val elasticsearchVersion = "8.17.0"
     val jacksonVersion = "2.17.0"
     val openTelemetryVersion = "1.29.0"
 
     // Apache 2.0
     // https://www.elastic.co/guide/en/elasticsearch/client/java-rest/current/java-rest-low.html
     api("org.elasticsearch.client", "elasticsearch-rest-client", elasticsearchVersion)
 
+    api("org.apache.httpcomponents.client5","httpclient5","5.4")
+
     // Apache 2.0
     // https://search.maven.org/artifact/com.google.code.findbugs/jsr305
     api("com.google.code.findbugs:jsr305:3.0.2")
@@ -271,6 +273,16 @@ dependencies {
     // Apache-2.0
     // https://github.com/awaitility/awaitility
     testImplementation("org.awaitility", "awaitility", "4.2.0")
+
+    // MIT
+    // https://github.com/mockito/mockito
+    testImplementation("org.mockito","mockito-core","5.12.0")
+
+    // Apache-2.0
+    // https://github.com/elastic/mocksocket
+    testImplementation("org.elasticsearch","mocksocket","1.2")
+
+
 }
 
 
@@ -285,6 +297,7 @@ class SpdxReporter(val dest: File) : ReportRenderer {
             "The Apache License, Version 2.0" to "Apache-2.0",
             "Apache License, Version 2.0" to "Apache-2.0",
             "The Apache Software License, Version 2.0" to "Apache-2.0",
+            "MIT License" to "MIT",
             "BSD Zero Clause License" to "0BSD",
             "Eclipse Public License 2.0" to "EPL-2.0",
             "Eclipse Public License v. 2.0" to "EPL-2.0",
@@ -311,7 +324,11 @@ class SpdxReporter(val dest: File) : ReportRenderer {
                 val depName = dep.group + ":" + dep.name
 
                 val info = LicenseDataCollector.multiModuleLicenseInfo(dep)
-                val depUrl = info.moduleUrls.first()
+                val depUrl = if (depName.startsWith("org.apache.httpcomponents")) {
+                    "https://hc.apache.org/"
+                } else {
+                    info.moduleUrls.first()
+                }
 
                 val licenseIds = info.licenses.mapNotNull { license ->
                     license.name?.let {

java-client/src/main/java/co/elastic/clients/elasticsearch/ElasticsearchAsyncClient.java

@@ -146,6 +146,7 @@
 import co.elastic.clients.elasticsearch.watcher.ElasticsearchWatcherAsyncClient;
 import co.elastic.clients.elasticsearch.xpack.ElasticsearchXpackAsyncClient;
 import co.elastic.clients.transport.ElasticsearchTransport;
+import co.elastic.clients.transport.ElasticsearchTransportConfig;
 import co.elastic.clients.transport.Endpoint;
 import co.elastic.clients.transport.JsonEndpoint;
 import co.elastic.clients.transport.Transport;
@@ -179,6 +180,23 @@
  */
 public class ElasticsearchAsyncClient extends ApiClient<ElasticsearchTransport, ElasticsearchAsyncClient> {
 
+	/**
+	 * Creates a client from a {@link ElasticsearchTransportConfig.Default}}
+	 * configuration created with an inline lambda expression.
+	 */
+	public static ElasticsearchAsyncClient of(
+			Function<ElasticsearchTransportConfig.Builder, ElasticsearchTransportConfig.Builder> fn) {
+		return new ElasticsearchAsyncClient(
+				fn.apply(new ElasticsearchTransportConfig.Builder()).build().buildTransport());
+	}
+
+	/**
+	 * Creates a client from an {@link ElasticsearchTransportConfig}.
+	 */
+	public ElasticsearchAsyncClient(ElasticsearchTransportConfig config) {
+		this(config.buildTransport());
+	}
+
 	public ElasticsearchAsyncClient(ElasticsearchTransport transport) {
 		super(transport, null);
 	}

java-client/src/main/java/co/elastic/clients/elasticsearch/ElasticsearchClient.java

@@ -147,6 +147,7 @@
 import co.elastic.clients.elasticsearch.watcher.ElasticsearchWatcherClient;
 import co.elastic.clients.elasticsearch.xpack.ElasticsearchXpackClient;
 import co.elastic.clients.transport.ElasticsearchTransport;
+import co.elastic.clients.transport.ElasticsearchTransportConfig;
 import co.elastic.clients.transport.Endpoint;
 import co.elastic.clients.transport.JsonEndpoint;
 import co.elastic.clients.transport.Transport;
@@ -180,6 +181,22 @@
  */
 public class ElasticsearchClient extends ApiClient<ElasticsearchTransport, ElasticsearchClient> {
 
+	/**
+	 * Creates a client from a {@link ElasticsearchTransportConfig.Default}}
+	 * configuration created with an inline lambda expression.
+	 */
+	public static ElasticsearchClient of(
+			Function<ElasticsearchTransportConfig.Builder, ElasticsearchTransportConfig.Builder> fn) {
+		return new ElasticsearchClient(fn.apply(new ElasticsearchTransportConfig.Builder()).build().buildTransport());
+	}
+
+	/**
+	 * Creates a client from an {@link ElasticsearchTransportConfig}.
+	 */
+	public ElasticsearchClient(ElasticsearchTransportConfig config) {
+		this(config.buildTransport());
+	}
+
 	public ElasticsearchClient(ElasticsearchTransport transport) {
 		super(transport, null);
 	}

java-client/src/main/java/co/elastic/clients/transport/DefaultTransportOptions.java

@@ -100,6 +100,12 @@ public Function<List<String>, Boolean> onWarnings() {
         return onWarnings;
     }
 
+    @Override
+    public void updateToken(String token) {
+        this.headers.put("Authorization", "Bearer " + token);
+    }
+
+
     @Override
     public boolean keepResponseBodyOnException() {
         return keepResponseBodyOnException;

java-client/src/main/java/co/elastic/clients/transport/ElasticsearchTransportBase.java

@@ -77,15 +77,9 @@ public abstract class ElasticsearchTransportBase implements ElasticsearchTranspo
         }
     }
 
-    private final TransportHttpClient httpClient;
-    private final Instrumentation instrumentation;
-
-    @Override
-    public void close() throws IOException {
-        httpClient.close();
-    }
-
-    private final JsonpMapper mapper;
+    protected final TransportHttpClient httpClient;
+    protected final Instrumentation instrumentation;
+    protected final JsonpMapper mapper;
     protected final TransportOptions transportOptions;
 
     public ElasticsearchTransportBase(TransportHttpClient httpClient, TransportOptions options,
@@ -113,6 +107,20 @@ public ElasticsearchTransportBase(
         this.instrumentation = instrumentation;
     }
 
+    /** INTERNAL, used only for tests. */
+    protected ElasticsearchTransportBase cloneWith(
+        @Nullable TransportOptions options,
+        @Nullable JsonpMapper mapper,
+        @Nullable Instrumentation instrumentation
+    ) {
+        throw new UnsupportedOperationException();
+    }
+
+    @Override
+    public void close() throws IOException {
+        httpClient.close();
+    }
+
     @Override
     public final JsonpMapper jsonpMapper() {
         return mapper;
@@ -123,6 +131,10 @@ public final TransportOptions options() {
         return transportOptions;
     }
 
+    public TransportHttpClient httpClient() {
+        return httpClient;
+    }
+
     @Override
     public final <RequestT, ResponseT, ErrorT> ResponseT performRequest(
         RequestT request,