-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Doc test - do not merge #12093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Doc test - do not merge #12093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inadvertent extra character causes aarch64 builds to fail.
This commit updates the kafka setup scripts to ensure that the kafka setup is clean between builds, by setting an explicit zookeeper data directory to be cleaned each time, and correctly overriding `log.dirs` instead of `log.dir` to ensure that the kafka logs are written and wiped in a consistent place each time, which helps when using the non-immutable images used in arm64 tests.
Co-authored-by: Ry Biesemeyer <[email protected]> Fixes: 11946
Release Manager builds were failing as `downloadEs` task was being needlessly run during `rake artifact:all` task. When run with `RELEASE=1`. this was causing build failures due to the non-availability of Elasticsearch release artifacts. This commit aims to avoid running the `downloadES` task when it is not needed, continuing the work done in elastic#11914 This commit also removes code that was repeated in different parts of the build script.
…led pipeline The worker threads were not correctly monitored for a worker loop exception resulting in a complete logstash crash upon any exception even when multiple pipelines are running. Now only the failed pipeline is terminated. If pipeline reloading is enabled, it is possible to edit the config and have that failed pipeline reloaded.
…f being created A pipeline in the process of being created was not marked as such in the pipeline registry resulting in a situation where a slow to initialize pipeline could be recreated on state convergence resulting in a PQ LockException because that pipeline was already existing and held the PQ lock. Replace native Java concurency with Ruby Mutex for simpler and straighforward implementation.
fixes a regression introduced with the api_key support for xpack monitoring and management in elastic#11864 which disabled the possibility to not use any authentication by relying on the default options and only enabling monitoring for example. It now ignores the default username option when no password is explicitly set.
This is a temporary fix. Currently the check task depends on the integrationt tests task, which means all dependant tasks will be resolved even if they're just registered instead of created. This resolution is a problem because the downloadES task will fail if, for the version we're building, Elasticsearch doesn't yet have a build we can download. So for now we'll remove this to unblock builds, but finding a way to compartimentalize failures is needed going forward
This script can be useful for preparing the environment for services like code scanners.
Integration plugins need a different header. For example, the plugin docs should to point to the integration repo rather than the input, output, filter, or codec repo. The new header also includes boilerplate text to indicate that the individual plugin is part of an integration rather than stand-alone. This work implements needed changes.
Although fossa has a fossa init tool to auto discover dependencies, it doesn't work well for Logstash. The mix of JRuby and Java allows for correct gradle detection but for Ruby we tell FOSSA to look at the lockfile, which we generate using ci/bootstrap_dependencies.sh This is a work in progress and covers 99% of our dependencies. As we get comfortable we'll have to uncomment a few ruby subprojects contained in the logstash source tree.
Prior to this commit, the value of `org.label-schema.license` and the values in `org.opencontainers.image.*` were not set, and therefore would be inherited from the base OS image.
Present OPTIONSFILE search in a way that reads first-match-wins, since that is what actually happens. Resolves: elastic#12145
…karenzone-api-mon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close without merging