Skip to content

Commit 5edb45f

Browse files
codebytereJohn Kleinschmidt
authored andcommitted
Unconditionally include report feature
nodejs/node#32242
1 parent a597d67 commit 5edb45f

File tree

1 file changed

+6
-18
lines changed

1 file changed

+6
-18
lines changed

patches/node/build_add_gn_build_files.patch

Lines changed: 6 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,14 @@ new file mode 100644
1010
index 0000000000000000000000000000000000000000..d1dcdfeb14994abb07914c2f8e927c67d1b463ab
1111
--- /dev/null
1212
+++ b/BUILD.gn
13-
@@ -0,0 +1,376 @@
13+
@@ -0,0 +1,360 @@
1414
+import("//electron/build/asar.gni")
1515
+import("//v8/gni/v8.gni")
1616
+
1717
+declare_args() {
1818
+ # Enable the V8 inspector protocol for use with node.
1919
+ node_enable_inspector = true
2020
+
21-
+ # Enable diagnostic reporting withing Node.js
22-
+ node_report = true
23-
+
2421
+ # Build node with SSL support.
2522
+ # The variable is called "openssl" for parity with node's GYP build.
2623
+ node_use_openssl = true
@@ -126,11 +123,6 @@ index 0000000000000000000000000000000000000000..d1dcdfeb14994abb07914c2f8e927c67
126123
+ } else {
127124
+ defines += [ "NODE_USE_V8_PLATFORM=0" ]
128125
+ }
129-
+ if (node_report) {
130-
+ defines += [ "NODE_REPORT=1" ]
131-
+ } else {
132-
+ defines += [ "NODE_REPORT=0" ]
133-
+ }
134126
+}
135127
+
136128
+config("node_lib_config") {
@@ -262,14 +254,6 @@ index 0000000000000000000000000000000000000000..d1dcdfeb14994abb07914c2f8e927c67
262254
+ libs += [ "CoreFoundation.framework" ]
263255
+ }
264256
+
265-
+ if (node_report) {
266-
+ sources += [
267-
+ "src/node_report.cc",
268-
+ "src/node_report_module.cc",
269-
+ "src/node_report_utils.cc",
270-
+ ]
271-
+ }
272-
+
273257
+ if (node_enable_inspector) {
274258
+ sources += [
275259
+ "src/inspector_agent.cc",
@@ -882,7 +866,7 @@ new file mode 100644
882866
index 0000000000000000000000000000000000000000..eb708f8d5095332b3d860987fa025b23776a37eb
883867
--- /dev/null
884868
+++ b/filenames.json
885-
@@ -0,0 +1,509 @@
869+
@@ -0,0 +1,513 @@
886870
+// This file is automatically generated by generate_gn_filenames_json.py
887871
+// DO NOT EDIT
888872
+{
@@ -1262,6 +1246,9 @@ index 0000000000000000000000000000000000000000..eb708f8d5095332b3d860987fa025b23
12621246
+ "src/node_process_events.cc",
12631247
+ "src/node_process_methods.cc",
12641248
+ "src/node_process_object.cc",
1249+
+ "src/node_report.cc",
1250+
+ "src/node_report_module.cc",
1251+
+ "src/node_report_utils.cc",
12651252
+ "src/node_serdes.cc",
12661253
+ "src/node_sockaddr.cc",
12671254
+ "src/node_stat_watcher.cc",
@@ -1352,6 +1339,7 @@ index 0000000000000000000000000000000000000000..eb708f8d5095332b3d860987fa025b23
13521339
+ "src/node_perf_common.h",
13531340
+ "src/node_platform.h",
13541341
+ "src/node_process.h",
1342+
+ "src/node_report.h",
13551343
+ "src/node_revert.h",
13561344
+ "src/node_root_certs.h",
13571345
+ "src/node_sockaddr.h",

0 commit comments

Comments
 (0)