Merge pull request #19 from jelhan/upgrade-ember-changeset

upgrade ember changeset to v3

Author: jelhan

.travis.yml

@@ -47,7 +47,6 @@ jobs:
 
     # we recommend new addons test the current and previous LTS
     # as well as latest stable release (bonus points to beta/canary)
-    - env: EMBER_TRY_SCENARIO=ember-3.13
     - env: EMBER_TRY_SCENARIO=ember-lts-3.16
     - env: EMBER_TRY_SCENARIO=ember-release
     - env: EMBER_TRY_SCENARIO=ember-beta

README.md

@@ -12,7 +12,7 @@ Compatibility
 
 * Ember Bootstrap v3
 * Ember Changeset and Ember Changeset Validations v2
-* Ember.js v3.13 or above
+* Ember.js v3.16 or above
 * Ember CLI v2.13 or above
 * Node.js v10 or above
 

addon/components/bs-form/element.js

@@ -4,12 +4,18 @@ import { A } from '@ember/array';
 import BsFormElement from 'ember-bootstrap/components/bs-form/element';
 
 export default BsFormElement.extend({
-
   hasValidator: notEmpty('model.validate'),
 
   setupValidations() {
+    // `Changeset.error` is a getter based on a tracked property. Since it's a
+    // derived state it's not working together with computed properties smoothly.
+    // As a work-a-round we observe the `Changeset._errors` computed property
+    // directly, which holds the state. This is not optimal cause it's private.
+    // Should refactor to native getter as soon as `<FormElement>` component
+    // of Ember Bootstrap supports native getters for `FormElement.errors`
+    // property.
     let key = `model.error.${this.get('property')}.validation`;
-    defineProperty(this, 'errors', computed(`${key}[]`, function() {
+    defineProperty(this, 'errors', computed(`model._errors`, function() {
       return A(this.get(key));
     }));
   }

config/ember-try.js

@@ -6,14 +6,6 @@ module.exports = async function() {
   return {
     useYarn: true,
     scenarios: [
-      {
-        name: 'ember-3.13',
-        npm: {
-          devDependencies: {
-            'ember-source': '~3.13.0'
-          }
-        }
-      },
       {
         name: 'ember-lts-3.16',
         npm: {

package.json

@@ -26,7 +26,7 @@
     "test:all": "ember try:each"
   },
   "dependencies": {
-    "ember-changeset-validations": "^2.1.0",
+    "ember-changeset-validations": "^3.0.0",
     "ember-cli-babel": "^7.17.2",
     "ember-cli-htmlbars": "^4.2.2"
   },