Don't consider library elements marked as __internal during exportRuntime

sbc100 · sbc100 · commit 17415c65a276 · 2022-03-07T12:17:54.000-08:00
We don't want folks to be able to export internal stuff, and it also
helps reduce code size for debug builds.
diff --git a/src/modules.js b/src/modules.js
@@ -441,7 +441,7 @@ function exportRuntime() {
   // Add JS library elements such as FS, GL, ENV, etc. These are prefixed with
   // '$ which indicates they are JS methods.
   for (const ident in LibraryManager.library) {
-    if (ident[0] === '$' && !isJsLibraryConfigIdentifier(ident)) {
+    if (ident[0] === '$' && !isJsLibraryConfigIdentifier(ident) && !LibraryManager.library[ident + '__internal']) {
       runtimeElements.push(ident.substr(1));
     }
   }
diff --git a/tests/other/metadce/hello_world.jssize b/tests/other/metadce/hello_world.jssize
@@ -1 +1 @@
-91448
+91067
diff --git a/tests/other/metadce/minimal.jssize b/tests/other/metadce/minimal.jssize
@@ -1 +1 @@
-88706
+88325

Original file line number	Diff line number	Diff line change
`@@ -441,7 +441,7 @@ function exportRuntime() {`
`441`	`441`	`// Add JS library elements such as FS, GL, ENV, etc. These are prefixed with`
`442`	`442`	`// '$ which indicates they are JS methods.`
`443`	`443`	`for (const ident in LibraryManager.library) {`
`444`		`- if (ident[0] === '$' && !isJsLibraryConfigIdentifier(ident)) {`
	`444`	`+ if (ident[0] === '$' && !isJsLibraryConfigIdentifier(ident) && !LibraryManager.library[ident + '__internal']) {`
`445`	`445`	`runtimeElements.push(ident.substr(1));`
`446`	`446`	`}`
`447`	`447`	`}`