WRN-20481: Fix screenshot test build fail #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected])
Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected])
Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected])
Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected])
Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected])
MikyungKim
changed the title
hong6316
approved these changes
Apr 7, 2022
Contributor
hong6316
left a comment
hong6316
left a comment
There was a problem hiding this comment.
Test result checked(#872~#873)
LGTM
hong6316
added a commit
that referenced
this pull request
Apr 11, 2022
* WRN-18582: Migrate to webpack5 (#264) * WRN-18582: webpack5 initial commit Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * WRN-18582: Fixed serve issue Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * WRN-18582: Added webpack cache config Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * applied more changes Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * Added changelog Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * fix Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * update `listen` to `startCallback` from webpack dev server Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * fix filename..ext issue Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * WRN-16762: Added support for tailwindcss and update dependencies (#263) * initial modules update(before wp5 update) * npm audit fix * Update package.json * fix lint errors * update CHANGELOG.md * Update package.json * revert CHANGELOG.mx * revert jest 27 * revert npm-shrinkwrap.json * revert pack/serve.js * for removing conflict with #262, revert versions * Update react-refresh-webpack-plugin version Co-authored-by: Mikyung Kim <[email protected]> * Update babel-jest version Co-authored-by: Mikyung Kim <[email protected]> * Update babel-plugin-dev-expression version Co-authored-by: Mikyung Kim <[email protected]> * remove unnecessary code * revert file permission * update dependencies * update package.json * Update package.json Co-authored-by: Mikyung Kim <[email protected]> * Update package.json * fix Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) Co-authored-by: Mikyung Kim <[email protected]> * update changelog and package.json Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) Co-authored-by: taeyoung.hong <[email protected]> * WRN-12124: Remove deprecated babel-eslint module (#261) * use @babel/eslint-parser * remove babel-preset-react-app * remove @babel/eslint-parser * Revert "remove @babel/eslint-parser" This reverts commit 1b8b37e. * Revert "remove babel-preset-react-app" This reverts commit b8579cb. * Revert "use @babel/eslint-parser" This reverts commit b73146a. * babel-eslint -> @babel/eslint-parser * unpinning enact repos * remove babel-eslint related word in README.md * Update README.md * modify changelog & readme * Update package.json Co-authored-by: Mikyung Kim <[email protected]> * Update README.md Co-authored-by: Mikyung Kim <[email protected]> * update npm-shrinkwrap.json * update @babel/core to the same version of dev-utils Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * Move some dependencies to dev dependencies Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) Co-authored-by: Mikyung Kim <[email protected]> * WRN-19252: Pass ProgressPlugin to VerboseLogPlugin (#265) Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * WRN-12748: Update eslint 8 related modules (#262) * update eslint 8 * eslint 8 changes strict package exports(#14706), call another method * revert js changes * Update package.json * restore eslintrc.js - 'prettier' (included 'prettier/babel', 'prettier/react') * Update package.json Co-authored-by: Mikyung Kim <[email protected]> Co-authored-by: Mikyung Kim <[email protected]> * WRN-19694: Update to React18 (#266) * update react version Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * update testing library for react18 Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * update react version Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * update dependencies Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * update version Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * update dev-utils branch Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * revert dev-utils version Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * WRN-20481: Fix screenshot test build fail (#267) * Added node-polyfill-webpack-plugin Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * added some comments Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * link dev-utils Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * WRN-20481: Fix lint error and revert packages version Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * update change log Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) * update dependencies Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected]) Co-authored-by: taeyoung.hong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we'd like to fix screenshot test build fail from sandstone.
With Webpack5, automatic Node.js polyfils are removed. (https://webpack.js.org/blog/2020-10-10-webpack-5-release/#automatic-nodejs-polyfills-removed)
But we need some modules from ui-test-utils to run screenshot tests.
So, I've added
node-polyfill-webpack-pluginto resolve those modules.Also, fixed lint error.
Enact-DCO-1.0-Signed-off-by: Mikyung Kim ([email protected])