Skip to content

Commit 5c79a2d

Browse files
authored
Remove buggy test to check if tasks can be posted on all native threads recursively from the emebdder. (flutter#16214)
This was never thread safe to shutdown of the concurrent message loop.
1 parent b98eadc commit 5c79a2d

File tree

1 file changed

+0
-35
lines changed

1 file changed

+0
-35
lines changed

shell/platform/embedder/tests/embedder_unittests.cc

Lines changed: 0 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -4006,40 +4006,5 @@ TEST_F(EmbedderTest, CanPostTaskToAllNativeThreads) {
40064006
ASSERT_FALSE(engine.is_valid());
40074007
}
40084008

4009-
TEST_F(EmbedderTest, CanPostTaskToAllNativeThreadsRecursively) {
4010-
EmbedderConfigBuilder builder(GetEmbedderContext());
4011-
4012-
builder.SetSoftwareRendererConfig();
4013-
4014-
static std::mutex engine_mutex;
4015-
static UniqueEngine engine;
4016-
static fml::AutoResetWaitableEvent event;
4017-
4018-
std::unique_lock engine_lock(engine_mutex);
4019-
engine.reset();
4020-
engine = builder.LaunchEngine();
4021-
ASSERT_TRUE(engine.is_valid());
4022-
ASSERT_EQ(FlutterEnginePostCallbackOnAllNativeThreads(
4023-
engine.get(),
4024-
[](FlutterNativeThreadType type, void* baton) {
4025-
// This should deadlock if the task mutex acquisition is
4026-
// busted.
4027-
std::scoped_lock engine_lock_inner(engine_mutex);
4028-
if (engine.is_valid()) {
4029-
ASSERT_EQ(FlutterEnginePostCallbackOnAllNativeThreads(
4030-
engine.get(),
4031-
[](FlutterNativeThreadType type,
4032-
void* baton) { event.Signal(); },
4033-
nullptr),
4034-
kSuccess);
4035-
}
4036-
},
4037-
&engine),
4038-
kSuccess);
4039-
engine_lock.unlock();
4040-
event.Wait();
4041-
engine.reset();
4042-
}
4043-
40444009
} // namespace testing
40454010
} // namespace flutter

0 commit comments

Comments
 (0)