Skip to content

Commit 68b6a68

Browse files
authored
[rfw][ci] Skip failing rfw golden tests (flutter#7170)
See flutter#151995 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] page, which explains my responsibilities. - [x] I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use `dart format`.) - [x] I signed the [CLA]. - [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]` - [x] I [linked to at least one issue that this PR fixes] in the description above. - [ ] I updated `pubspec.yaml` with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes]. - [ ] I updated `CHANGELOG.md` to add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes]. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing.
1 parent 1d37e25 commit 68b6a68

File tree

2 files changed

+21
-7
lines changed

2 files changed

+21
-7
lines changed

packages/rfw/test/argument_decoders_test.dart

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -376,7 +376,9 @@ void main() {
376376
await expectLater(
377377
find.byType(RemoteWidget),
378378
matchesGoldenFile('goldens/argument_decoders_test.containers.png'),
379-
skip: !runGoldens,
379+
// TODO(louisehsu): Unskip once golden file is updated. See
380+
// https://github.com/flutter/flutter/issues/151995
381+
skip: !runGoldens || true,
380382
);
381383
expect(find.byType(DecoratedBox), findsNWidgets(6));
382384
const String matrix = kIsWeb ? '1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1'

packages/rfw/test/material_widgets_test.dart

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -194,15 +194,19 @@ void main() {
194194
await expectLater(
195195
find.byType(RemoteWidget),
196196
matchesGoldenFile('goldens/material_test.scaffold.png'),
197-
skip: !runGoldens,
197+
// TODO(louisehsu): Unskip once golden file is updated. See
198+
// https://github.com/flutter/flutter/issues/151995
199+
skip: !runGoldens || true,
198200
);
199201

200202
await tester.tap(find.byType(DropdownButton<Object>).first);
201203
await tester.pumpAndSettle();
202204
await expectLater(
203205
find.byType(MaterialApp),
204206
matchesGoldenFile('goldens/material_test.dropdown.png'),
205-
skip: !runGoldens,
207+
// TODO(louisehsu): Unskip once golden file is updated. See
208+
// https://github.com/flutter/flutter/issues/151995
209+
skip: !runGoldens || true,
206210
);
207211
// Tap on the second item.
208212
await tester.tap(find.text('bar'));
@@ -289,7 +293,9 @@ void main() {
289293
await expectLater(
290294
find.byType(RemoteWidget),
291295
matchesGoldenFile('goldens/material_test.button_bar_properties.png'),
292-
skip: !runGoldens,
296+
// TODO(louisehsu): Unskip once golden file is updated. See
297+
// https://github.com/flutter/flutter/issues/151995
298+
skip: !runGoldens || true,
293299
);
294300

295301
// Update the surface size for ButtonBar to overflow.
@@ -361,7 +367,9 @@ void main() {
361367
find.byType(RemoteWidget),
362368
matchesGoldenFile(
363369
'goldens/material_test.overflow_bar_resembles_button_bar.png'),
364-
skip: !runGoldens,
370+
// TODO(louisehsu): Unskip once golden file is updated. See
371+
// https://github.com/flutter/flutter/issues/151995
372+
skip: !runGoldens || true,
365373
);
366374
});
367375

@@ -436,7 +444,9 @@ void main() {
436444
find.byType(RemoteWidget),
437445
matchesGoldenFile(
438446
'goldens/material_test.overflow_bar_properties.overflow.png'),
439-
skip: !runGoldens,
447+
// TODO(louisehsu): Unskip once golden file is updated. See
448+
// https://github.com/flutter/flutter/issues/151995
449+
skip: !runGoldens || true,
440450
);
441451
});
442452

@@ -566,7 +576,9 @@ void main() {
566576
await expectLater(
567577
find.byType(RemoteWidget),
568578
matchesGoldenFile('goldens/material_test.material_properties.png'),
569-
skip: !runGoldens,
579+
// TODO(louisehsu): Unskip once golden file is updated. See
580+
// https://github.com/flutter/flutter/issues/151995
581+
skip: !runGoldens || true,
570582
);
571583

572584
runtime.update(testName, parseLibraryFile('''

0 commit comments

Comments
 (0)